fix(git): fix exclude filter in repo Git scan mode
#5526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvagaytsev
force-pushed
the
fix/align-git-handler-behavior
branch
6 times, most recently
from
2ad4d5f
to
4850451
Compare
vvagaytsev
changed the title
exclude filter in GitRepoHandlerexclude filter in GitRepoHandler
vvagaytsev
force-pushed
the
fix/align-git-handler-behavior
branch
2 times, most recently
from
db6115b
to
205c71d
Compare
vvagaytsev
changed the title
exclude filter in GitRepoHandlerexclude filter in repo Git scan mode
vvagaytsev
force-pushed
the
fix/align-git-handler-behavior
branch
from
0f3f171
to
8fbe613
Compare
More robust way of the default `Dockerfile` exclusion. It doesn't have to be a first element in the array of files.
Align `exclude` filter behavior between `subtree` and `repo` Git repository scan modes. Now both `GitHandler` and `GitRepoHandler` behave identically if any exclusions are configured. chore: amend
vvagaytsev
force-pushed
the
fix/align-git-handler-behavior
branch
from
8fbe613
to
c15d394
Compare
stefreak
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR aligns the
excludefile filter behavior betweenGitRepoHandlerandGitHandler.Also, it adds a few more test cases to cover more scenarios.
The behavior of
GitHandlerwas taken as a reference, because it's been there for a long time before we switched the default repo scanner toGitRepoHandlerin #5399 (0.13.20).Which issue(s) this PR fixes:
Fixes some of the
GitRepoHandlertest failures that were introduced in #5472. Those were enabled only forGitHandlerthat passed all the tests.Special notes for your reviewer: