Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cloud): helpers to create and update secrets #6068

Merged
merged 20 commits into from
May 24, 2024

Conversation

vvagaytsev
Copy link
Collaborator

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@vvagaytsev vvagaytsev changed the title refactor(cloud) secrets create and update refactor(cloud) helpers for secret creation May 23, 2024
@vvagaytsev vvagaytsev changed the title refactor(cloud) helpers for secret creation refactor(cloud): helpers for secret creation May 23, 2024
@vvagaytsev vvagaytsev requested a review from twelvemo May 23, 2024 13:33
@vvagaytsev vvagaytsev marked this pull request as draft May 23, 2024 14:25
@vvagaytsev vvagaytsev marked this pull request as ready for review May 23, 2024 15:08
twelvemo
twelvemo previously approved these changes May 23, 2024
Copy link
Collaborator

@twelvemo twelvemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good!

@vvagaytsev vvagaytsev added this pull request to the merge queue May 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 23, 2024
@vvagaytsev vvagaytsev marked this pull request as draft May 23, 2024 15:43
@vvagaytsev
Copy link
Collaborator Author

Added one more fix in 2bf42cc

@vvagaytsev vvagaytsev force-pushed the refactor/secrets-create-and-update branch from 54fd3e7 to 5195f0e Compare May 23, 2024 18:13
@vvagaytsev vvagaytsev changed the title refactor(cloud): helpers for secret creation refactor(cloud): helpers to create and update secrets May 23, 2024
@vvagaytsev vvagaytsev marked this pull request as ready for review May 23, 2024 18:18
@vvagaytsev vvagaytsev enabled auto-merge May 23, 2024 18:50
@vvagaytsev vvagaytsev added this pull request to the merge queue May 24, 2024
Merged via the queue into main with commit 11059b7 May 24, 2024
40 checks passed
@vvagaytsev vvagaytsev deleted the refactor/secrets-create-and-update branch May 24, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants