-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(cloud): helpers to create and update secrets #6068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvagaytsev
changed the title
refactor(cloud) secrets create and update
refactor(cloud) helpers for secret creation
May 23, 2024
vvagaytsev
changed the title
refactor(cloud) helpers for secret creation
refactor(cloud): helpers for secret creation
May 23, 2024
twelvemo
previously approved these changes
May 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 looks good!
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
May 23, 2024
Added one more fix in 2bf42cc |
Detailed messages are printed in the loop below.
It was already addressed in #6065
vvagaytsev
force-pushed
the
refactor/secrets-create-and-update
branch
from
May 23, 2024 18:13
54fd3e7
to
5195f0e
Compare
vvagaytsev
changed the title
refactor(cloud): helpers for secret creation
refactor(cloud): helpers to create and update secrets
May 23, 2024
twelvemo
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: