refactor(secrets): payload creation for secrets update command
#6106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
A follow-up PR to fix some bugs introduced in #6068.
This also gets rid of unnecessary type
UpdateSecretBody. ItsnewValuefield was set but never read. The secrets to be updated did never get updated values.Moreover, the
UpdateSecretBody.newValuewas set incorrectly, because it used index-based access on array with the secret id/name used as an index value. That resulted toundefinedvalue.Which issue(s) this PR fixes:
Patches #6068
Special notes for your reviewer:
refactorcommit header because it's a follow-up PR, not a bug fix for an issue that exists in an official release.