Skip to content
This repository has been archived by the owner on Apr 7, 2020. It is now read-only.

Adapt terraformer Pod spec to the latest image #624

Merged
merged 1 commit into from
Apr 2, 2020
Merged

Adapt terraformer Pod spec to the latest image #624

merged 1 commit into from
Apr 2, 2020

Conversation

ialidzhikov
Copy link
Contributor

@ialidzhikov ialidzhikov commented Mar 18, 2020 •
edited by rfranzke

What this PR does / why we need it:
Adapt terraformer Pod spec to the changes in gardener/terraformer#36.

Which issue(s) this PR fixes:
Fixes #597
Fixes #620

Special notes for your reviewer:
This PR requires:

Release note:

`g/gardener-extensions` does now require the `g/terraformer@v1.0.0`.

@ialidzhikov ialidzhikov requested a review from a team as a code owner March 18, 2020 18:18
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 18, 2020
This was referenced Mar 18, 2020
Merged
Merged
Merged
Merged
timebertt
timebertt previously approved these changes Mar 19, 2020
View reviewed changes
Copy link
Contributor

@timebertt timebertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@timebertt
Copy link
Contributor

I assume, you will wait for the upgrade PR for terraformer and then merge this PR, right?

This was referenced Mar 20, 2020
Merged
Merged
@rfranzke rfranzke added the reviewed/do-not-merge Has no approval for merging, may not be merged as it may break things or be of poor quality label Mar 23, 2020
@ialidzhikov
Adapt terraformer Pod spec to the latest image
d55dd71 
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 2, 2020
@rfranzke rfranzke mentioned this pull request Apr 2, 2020
Closed
rfranzke
rfranzke approved these changes Apr 2, 2020
View reviewed changes
Copy link
Contributor

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rfranzke rfranzke removed the reviewed/do-not-merge Has no approval for merging, may not be merged as it may break things or be of poor quality label Apr 2, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 2, 2020
@ialidzhikov ialidzhikov merged commit df061f8 into master Apr 2, 2020
@ialidzhikov ialidzhikov deleted the fix/handle-sigterm branch April 2, 2020 09:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rfranzke rfranzke rfranzke approved these changes

@timebertt timebertt timebertt left review comments

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cluster creation hangs due to subnet conflicts SIGTERM is not sent to terraformer process
5 participants
@ialidzhikov @timebertt @rfranzke @gardener-robot-ci-2 @gardener-robot-ci-3