Gracefully shutdown the terraform process #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-1
added
needs/ok-to-test
rfranzke
reviewed
Mar 17, 2020
There was a problem hiding this comment.
Tested with AWS - works perfectly, great!
$ k -n shoot--foobar--aws logs infrastructure.infra.tf-apply-mq7bq -f
Initializing the backend...
[...]
* provider.aws: version = "~> 2.26"
Terraform has been successfully initialized!
You may now begin working with Terraform. Try running "terraform plan" to see
any changes that are required for your infrastructure. All Terraform commands
should now work.
If you ever set or change modules or backend configuration for Terraform,
rerun this command to reinitialize your working directory. If you forget, other
commands will detect it and remind you to do so if necessary.
aws_iam_role.nodes: Creating...
aws_vpc_dhcp_options.vpc_dhcp_options: Creating...
aws_vpc.vpc: Creating...
aws_iam_role.bastions: Creating...
Tue Mar 17 06:04:30 UTC 2020 Sending SIGTERM to terraform.sh process 7.
Tue Mar 17 06:04:30 UTC 2020 Waiting for terraform.sh process 7 to complete...
Tue Mar 17 06:04:30 UTC 2020 Sending SIGTERM to terraform process 31.
Interrupt received.
Please wait for Terraform to exit or data loss may occur.
Gracefully shutting down...
Stopping operation...
Tue Mar 17 06:04:30 UTC 2020 Waiting for terraform process 31 to complete...
aws_vpc_dhcp_options.vpc_dhcp_options: Creation complete after 1s [id=dopt-0bb24fabf45522cbc]
aws_iam_role.bastions: Creation complete after 1s [id=shoot--foobar--aws-bastions]
aws_iam_role.nodes: Creation complete after 2s [id=shoot--foobar--aws-nodes]
aws_vpc.vpc: Creation complete after 4s [id=vpc-0f2faa33eba498d7d]
Apply complete! Resources: 4 added, 0 changed, 0 destroyed.
Outputs:
nodes_role_arn = arn:aws:iam::***:role/shoot--foobar--aws-nodes
vpc_id = vpc-0f2faa33eba498d7d
Tue Mar 17 06:04:33 UTC 2020 Terraform process 31 completed.
ConfigMap successfully updated with terraform state.
Tue Mar 17 06:04:34 UTC 2020 Command executed successful.
Tue Mar 17 06:04:34 UTC 2020 terraform.sh process 7 completed.
Tue Mar 17 06:04:34 UTC 2020 terraform.sh exited with 143.
ialidzhikov
force-pushed
the
fix/handle-sigterm
branch
from
bb85370
to
d135fac
Compare
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
ialidzhikov
commented
Mar 17, 2020
rfranzke
added
the
reviewed/do-not-merge
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
ialidzhikov
force-pushed
the
fix/handle-sigterm
branch
from
d135fac
to
3d129a2
Compare
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
ialidzhikov
added
reviewed/ok-to-test
gardener-robot-ci-3
added
needs/ok-to-test
ialidzhikov
removed
the
reviewed/do-not-merge
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently signals sent to PID 1 in the terraformer image are not forwarded to the child processes as PID 1 is
sh. This prevents the terraform process itself to receive a SIGTERM and start graceful termination. After aterminationGracePeriodSeconds, the terraformer Pod can be SIGKILL-ed and the terraform process itself can lose its current terraform.tfstate.This PR:
terraformer.shprocess which runs as PID 1 and sends SIGTERM to the running childterraform.shprocess (if any) on termination and waits for its completionterraform.shto sent SIGTERM to the running terraform process (if any) on termination and waits for its completion. On the other side, if the current command isapply, terraform stops creating new resources and waits only for the creation of the resources which were already in creating when the SIGTERM was sent.Which issue(s) this PR fixes:
Ref gardener-attic/gardener-extensions#597
Special notes for your reviewer:
Release note: