Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance CRD validation #28

Merged
merged 2 commits into from
Apr 29, 2020
Merged

Enhance CRD validation #28

merged 2 commits into from
Apr 29, 2020

Conversation

timuthy
Copy link
Contributor

@timuthy timuthy commented Apr 29, 2020 •
edited

What this PR does / why we need it:
This PR harmonizes the CRD files in the examples and charts directories. It also adds a 64 char limit to the CRD validation for the commonName field.

Release note:

The `commonName` field of certificates is now subjected to a 64 characters limit.

@timuthy timuthy requested a review from a team as a code owner April 29, 2020 14:34
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 29, 2020
@timuthy timuthy changed the title Enhancement/validation Enhance CRD validation Apr 29, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 29, 2020
MartinWeindel
MartinWeindel approved these changes Apr 29, 2020
View reviewed changes
Copy link
Member

@MartinWeindel MartinWeindel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Really cool to check the length of the common name

@MartinWeindel MartinWeindel merged commit 31adf7c into gardener:master Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinWeindel MartinWeindel MartinWeindel approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@timuthy @MartinWeindel @gardener-robot-ci-1 @gardener-robot-ci-3