Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build gardener/gardener dev images #181

Merged
merged 4 commits into from
Apr 12, 2022
Merged

Build gardener/gardener dev images #181

merged 4 commits into from
Apr 12, 2022

Conversation

oliver-goetz
Copy link
Member

@oliver-goetz oliver-goetz commented Apr 8, 2022 •
edited
Loading

/kind enhancement

What this PR does / why we need it:
Builds gardener/gardener dev images in prow.

presubmit jobs:

  • pull-gardener-verify-image-build builds all targets of Dockerfile but is not pushing the results anywhere
  • pull-gardener-publish-test-images is an optional job to build and publish images of an PR to eu.gcr.io/gardener-project/gardener
    • it it started on request in a PR /test pull-gardener-publish-test-images and takes about 5 minutes
    • these are examples how the jobs look like in prow
  • Both jobs exist for release branches too pull-gardener-verify-image-build-release, pull-gardener-publish-test-images-release

postsubmit jobs:

  • post-gardener-build-dev-images builds and publishes images from master branch to eu.gcr.io/gardener-project/gardener
    • is not running when only VERSION file is changed to not interfere release builds
    • these are examples how the jobs look like in prow

This approach is slightly different than the current setup, but still allows to build test images from a PR.
Another option could be changing pull-gardener-publish-test-images to a non-optional prow job, to publish images from each commit of any PR and remove pull-gardener-verify-image-build

A minor change is updating kaniko to the latest patch level 1.8.1.

Which issue(s) this PR fixes:
Fixes #180 partly

Special notes for your reviewer:
concourse-ci/publish should be deactivated in gardener/gardener when merging this PR

@gardener-prow gardener-prow bot added the kind/enhancement Enhancement, improvement, extension label Apr 8, 2022
@gardener-prow gardener-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cla: no Indicates the PR's author has not signed the cla-assistant.io CLA. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. and removed cla: no Indicates the PR's author has not signed the cla-assistant.io CLA. labels Apr 8, 2022
timebertt
timebertt reviewed Apr 12, 2022
View reviewed changes
Copy link
Member

@timebertt timebertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: we need make councourse-ci/publish not required anymore in branch protection.

timebertt
timebertt reviewed Apr 12, 2022
View reviewed changes
Copy link
Member

@timebertt timebertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold
for @oliver-goetz

@gardener-prow gardener-prow bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Apr 12, 2022
@oliver-goetz
Copy link
Member Author

/lgtm
/unhold

@gardener-prow
Copy link

gardener-prow bot commented Apr 12, 2022

@oliver-goetz: you cannot LGTM your own PR.

In response to this:

/lgtm
/unhold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gardener-prow gardener-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 12, 2022
@gardener-prow
Copy link

gardener-prow bot commented Apr 12, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oliver-goetz, timebertt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [oliver-goetz,timebertt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot merged commit a235426 into gardener:master Apr 12, 2022
@gardener-prow
Copy link

gardener-prow bot commented Apr 12, 2022

@oliver-goetz: Updated the following 2 configmaps:

  • job-config configmap in namespace prow at cluster gardener-prow-trusted using the following files:
    • key build-gardener-images.yaml using file ``
    • key gardener-build-dev-images.yaml using file config/jobs/gardener/gardener-build-dev-images.yaml
    • key gardener-test-builds.yaml using file config/jobs/gardener/gardener-test-builds.yaml
    • key gardener-build-dev-images-release.yaml using file config/jobs/gardener/release/gardener-build-dev-images-release.yaml
    • key gardener-test-builds-release.yaml using file config/jobs/gardener/release/gardener-test-builds-release.yaml
  • config configmap in namespace prow at cluster gardener-prow-trusted using the following files:
    • key config.yaml using file config/prow/config.yaml

In response to this:

/kind enhancement

What this PR does / why we need it:
Builds gardener/gardener dev images in prow.

presubmit jobs:

  • pull-gardener-verify-image-build builds all targets of Dockerfile but is not pushing the results anywhere
  • these are examples how the jobs look like in prow
  • pull-gardener-publish-test-images is an optional job to build and publish images of an PR to eu.gcr.io/gardener-project/gardener
  • it it started on request in a PR /test pull-gardener-publish-test-images and takes about 5 minutes
  • Both jobs exist for release branches too pull-gardener-verify-image-build-release, pull-gardener-publish-test-images-release

postsubmit jobs:

  • post-gardener-build-dev-images builds and publishes images from master branch to eu.gcr.io/gardener-project/gardener
  • is not running when only VERSION file is changed to not interfere release builds

This approach is slightly different than the current setup, but still allows to build test images from a PR.
Another option could be changing pull-gardener-publish-test-images to a non-optional prow job, to publish images from each commit of any PR and remove pull-gardener-verify-image-build

A minor change is updating kaniko to the latest patch level 1.8.1.

Which issue(s) this PR fixes:
Fixes #180 partly

Special notes for your reviewer:
concourse-ci/publish should be deactivated in gardener/gardener when merging this PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@oliver-goetz oliver-goetz mentioned this pull request Apr 12, 2022
Open
@oliver-goetz oliver-goetz deleted the gardener-dev-builds branch April 12, 2022 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timebertt timebertt timebertt left review comments

@rfranzke rfranzke Awaiting requested review from rfranzke

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build gardener/gardener images with prow/kaniko
2 participants
@oliver-goetz @timebertt