Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new prow job with feature gate turned off to run etcd-druid e2e tests with etcd-custom-image. #1080

Merged
merged 2 commits into from
Jan 8, 2024

Conversation

ishan16696
Copy link
Member

@ishan16696 ishan16696 commented Jan 4, 2024

/kind enhancement

What this PR does / why we need it:
The UseEtcdWrapper feature in etcd-druid is transitioning from alpha to beta stage, and will be set as the default option in etcd-druid. Hence, etcd-wrapper will be used to run druid end-to-end (e2e) tests in pipeline.

However, we will continue to support etcd-custom-image(nondistroless-etcd). Therefore, the druid pipeline still requires to run druid e2e tests with etcd-custom-image.

Which issue(s) this PR fixes:
Fixes # gardener/etcd-druid#743

Special notes for your reviewer:
cc @aaronfern @shreyas-s-rao

@gardener-prow gardener-prow bot added the kind/enhancement Enhancement, improvement, extension label Jan 4, 2024
@gardener-prow gardener-prow bot added cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 4, 2024
@ishan16696
Copy link
Member Author

/do-not-merge

@gardener-prow gardener-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 4, 2024
Copy link

@shreyas-s-rao shreyas-s-rao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 6, 2024
Copy link

gardener-prow bot commented Jan 6, 2024

LGTM label has been added.

Git tree hash: 5efdf41fe74944dc5b6e7bb284d63c5d3290213d

@ishan16696
Copy link
Member Author

/do-not-merge

This PR now can be merged.

@ishan16696
Copy link
Member Author

/cc @oliver-goetz

@oliver-goetz
Copy link
Member

/approve

Copy link

gardener-prow bot commented Jan 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oliver-goetz, shreyas-s-rao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2024
@gardener-prow gardener-prow bot merged commit 6bc75c4 into gardener:master Jan 8, 2024
7 checks passed
Copy link

gardener-prow bot commented Jan 8, 2024

@ishan16696: Updated the job-config configmap in namespace prow at cluster gardener-prow-trusted using the following files:

  • key druid-e2e-kind-alpha-features.yaml using file ``
  • key druid-e2e-kind-nondistroless-etcd.yaml using file config/jobs/etcd-druid/druid-e2e-kind-nondistroless-etcd.yaml

In response to this:

/kind enhancement

What this PR does / why we need it:
The UseEtcdWrapper feature in etcd-druid is transitioning from alpha to beta stage, and will be set as the default option in etcd-druid. Hence, etcd-wrapper will be used to run druid end-to-end (e2e) tests in pipeline.

However, we will continue to support etcd-custom-image(nondistroless-etcd). Therefore, the druid pipeline still requires to run druid e2e tests with etcd-custom-image.

Which issue(s) this PR fixes:
Fixes # gardener/etcd-druid#743

Special notes for your reviewer:
cc @aaronfern @shreyas-s-rao

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants