-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new prow job with feature gate turned off to run etcd-druid e2e tests with etcd-custom-image. #1080
Conversation
…ests with etcd-custom-image.
/do-not-merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 5efdf41fe74944dc5b6e7bb284d63c5d3290213d
|
This PR now can be merged. |
/cc @oliver-goetz |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oliver-goetz, shreyas-s-rao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ishan16696: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/kind enhancement
What this PR does / why we need it:
The
UseEtcdWrapper
feature in etcd-druid is transitioning from alpha to beta stage, and will be set as the default option in etcd-druid. Hence,etcd-wrapper
will be used to run druid end-to-end (e2e) tests in pipeline.However, we will continue to support etcd-custom-image(nondistroless-etcd). Therefore, the druid pipeline still requires to run druid e2e tests with etcd-custom-image.
Which issue(s) this PR fixes:
Fixes # gardener/etcd-druid#743
Special notes for your reviewer:
cc @aaronfern @shreyas-s-rao