Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS update recommendation should take CRI support into account #1111

Closed
voelzmo opened this issue Sep 28, 2021 · 2 comments · Fixed by #1199
Closed

OS update recommendation should take CRI support into account #1111

voelzmo opened this issue Sep 28, 2021 · 2 comments · Fixed by #1199
Labels
component/dashboard Gardener Dashboard kind/enhancement Enhancement, improvement, extension lifecycle/stale Nobody worked on this for 6 months (will further age) status/closed Issue is closed (either delivered or triaged)

Comments

@voelzmo
Copy link
Member

voelzmo commented Sep 28, 2021

What would you like to be added:
As a user, I'd like to get recommendations for updating my OS only if it supports the currently selected container runtime for my Shoot.

Why is this needed:
In the future, we might release e.g. a new gardenlinux version without support for docker. Shoot owners who have docker configured for their worker should not get the recommendation to update to this version.

@voelzmo voelzmo added component/dashboard Gardener Dashboard kind/enhancement Enhancement, improvement, extension labels Sep 28, 2021
@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Mar 28, 2022
@grolu
Copy link
Contributor

grolu commented May 6, 2022

@voelzmo Please have a look at the referenced PR. We still recommend the update, I think it is not a solution tom stay on an outdated OS anyway. But we make the user aware that changing the OS will require a change of the Container Runtime. This change is no longer made implicitly. The user needs to explicitly select a runtime so he cannot accidentally change the container runtime by upgrading the worker image. I hope this is sufficient.

@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label May 11, 2022
@voelzmo
Copy link
Member Author

voelzmo commented May 23, 2022

Only seeing this now, sorry. Looks good to me, especially given that going forward people will have to pick containerd anyways for newer k8s versions and all of our OS images now support that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/dashboard Gardener Dashboard kind/enhancement Enhancement, improvement, extension lifecycle/stale Nobody worked on this for 6 months (will further age) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants