Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve container runtime handling when machine image changes #1199

Merged
merged 6 commits into from
May 11, 2022

Conversation

grolu
Copy link
Contributor

@grolu grolu commented May 6, 2022

What this PR does / why we need it:

  • When selecting a machine image that does not support the currently selected container runtime, the Dashboard does no longer implicitly set the container runtime to something else
  • If the user switches back to another image that supports the previously selected runtime it is restored
  • This also applies for new clusters, I think it makes sense as the user may not notice it otherwise
  • Container Runtime is now a required field also for not new clusters. There might still exist some very old worker groups without a container runtime set explicitly. However, modifying those would cause Gardener to add this now required field automatically anyway

Screen Shot 2022-05-10 at 16 52 44

Which issue(s) this PR fixes:
Fixes #1111

Special notes for your reviewer:

Release note:

When selecting a machine image that does not support the currently selected container runtime, the Dashboard does no longer implicitly set the container runtime to something else

@gardener-robot gardener-robot added needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels May 6, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 6, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 6, 2022
@gardener-robot
Copy link

@holgerkoser You have pull request review open invite, please check

@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 10, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 10, 2022
grolu and others added 2 commits May 11, 2022 09:10
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 11, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 11, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 11, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 11, 2022
Copy link
Contributor

@petersutter petersutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels May 11, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 11, 2022
@grolu grolu merged commit 3ff8ea9 into master May 11, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label May 11, 2022
@grolu grolu deleted the bug/fix_os_update_cri branch May 11, 2022 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OS update recommendation should take CRI support into account
7 participants