Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard Link w/o Dashboard Addon #160

Closed
vlerenc opened this issue Aug 8, 2018 · 6 comments · Fixed by #190
Closed

Dashboard Link w/o Dashboard Addon #160

vlerenc opened this issue Aug 8, 2018 · 6 comments · Fixed by #190
Assignees
Labels
component/dashboard Gardener Dashboard kind/bug Bug

Comments

@vlerenc
Copy link
Member

vlerenc commented Aug 8, 2018

I have created a cluster without Kubernetes dashboard (less attack surface), but the Gardener Dashboard (still) shows a Kubernetes dashboard link in the cluster details:
screen shot 2018-08-08 at 15 53 37

@vlerenc vlerenc added kind/bug Bug component/dashboard Gardener Dashboard labels Aug 8, 2018
@grolu
Copy link
Contributor

grolu commented Aug 8, 2018

We currently always show the dashboard link when we are able to get a cluster URL from the cluster kubeconfig (we generate the url by adding /ui). There is no logic in place to check if there is actually a dashboard running in a specific cluster. To determine, if there is actually a dashboard running, we would need to look for the kubernetes-dashboard service when fetching the shoot info, right? @petersutter @holgerkoser

@petersutter
Copy link
Member

..or we could check the shoot spec for the dashboard addon?

@grolu
Copy link
Contributor

grolu commented Aug 8, 2018

Yes this would cover most cases, at least the straight forward ones.

@vlerenc
Copy link
Member Author

vlerenc commented Aug 8, 2018

Yes, that's what I meant. I was too lazy painting red circles around the addon and the monitoring section.

@holgerkoser
Copy link
Member

holgerkoser commented Aug 8, 2018

From my point of view in general the referrer is not responsible for the availability or the existence of the target. I don't see a problem with showing a link which will result in 404. This indicates that the dashboard is not deployed. To me this is not a bug but an enhancement. Anyway the url /ui redirect is removed (kubernetes/kubernetes#53766).

@petersutter
Copy link
Member

regarding /ui:
we already have the path configurable but we should consider removing the default, which points to /ui: https://github.com/gardener/dashboard/blob/master/frontend/src/store/modules/shoots.js#L165-L166

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/dashboard Gardener Dashboard kind/bug Bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants