-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dashboard Link w/o Dashboard Addon #160
Comments
We currently always show the dashboard link when we are able to get a cluster URL from the cluster kubeconfig (we generate the url by adding /ui). There is no logic in place to check if there is actually a dashboard running in a specific cluster. To determine, if there is actually a dashboard running, we would need to look for the kubernetes-dashboard service when fetching the shoot info, right? @petersutter @holgerkoser |
..or we could check the shoot spec for the dashboard addon? |
Yes this would cover most cases, at least the straight forward ones. |
Yes, that's what I meant. I was too lazy painting red circles around the addon and the monitoring section. |
From my point of view in general the referrer is not responsible for the availability or the existence of the target. I don't see a problem with showing a link which will result in 404. This indicates that the dashboard is not deployed. To me this is not a bug but an enhancement. Anyway the url /ui redirect is removed (kubernetes/kubernetes#53766). |
regarding /ui: |
I have created a cluster without Kubernetes dashboard (less attack surface), but the Gardener Dashboard (still) shows a Kubernetes dashboard link in the cluster details:
The text was updated successfully, but these errors were encountered: