Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lazy load dialogs #164

Closed
grolu opened this issue Aug 10, 2018 · 1 comment · Fixed by #172
Closed

Lazy load dialogs #164

grolu opened this issue Aug 10, 2018 · 1 comment · Fixed by #172
Assignees
@grolu

Comments

@grolu
Copy link
Contributor

grolu commented Aug 10, 2018

Currently, all dialogs are rendered even if they are never presented to the user. Especially on the cluster list page this can lead to pre-rendering of hundreds of dialogs. We could improve memory and cpu consumption by adding lazy loading to the dialogs. However, we need to make sure that this does not introduce unintended side effects.
@grolu grolu self-assigned this Aug 13, 2018
grolu added a commit that referenced this issue Aug 13, 2018
@grolu
Lazy load dialogs #164
225d2df 
- Added lazy attribute to all confirm input dialogs, this is especially useful to prevent pre-rendering of all version upgrade dialogs in a shoot list (including calculation of available updates / upgrades selection items)
- Added v-if statement to create cluster dialog to prevent pre-rendering
@grolu
Copy link
Contributor Author

grolu commented Aug 14, 2018

Done for all confirm dialogs as well as create cluster. This covers the most expensive cases. For all other dialogs it would be possible to lazy load them, too. However it makes things unnecessarily complicated, especially when working with $ref.

@grolu grolu closed this as completed Aug 14, 2018
@grolu grolu mentioned this issue Aug 14, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grolu grolu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dialog Improvements and Lazy Loading gardener/dashboard
1 participant
@grolu