Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enabled button per accident in add AWS secret dialog #169

Closed
freegroup opened this issue Aug 14, 2018 · 1 comment
Closed

enabled button per accident in add AWS secret dialog #169

freegroup opened this issue Aug 14, 2018 · 1 comment
Labels
kind/bug Bug

Comments

@freegroup
Copy link

freegroup commented Aug 14, 2018 •
edited

as shown below all dialogs has a disabled Add Secret button per default. The AWS didn't.
The UX pattern for this kind of dialogs are broken.

bad "Add Secret" button

bildschirmfoto 2018-08-14 um 14 44 55

good buttons

bildschirmfoto 2018-08-14 um 14 45 05

bildschirmfoto 2018-08-14 um 14 45 12

bildschirmfoto 2018-08-14 um 14 45 20
@grolu grolu added the kind/bug Bug label Aug 14, 2018
grolu added a commit that referenced this issue Aug 14, 2018
@grolu
[Fix] make fields required in add azure secret dialog #169
3f87d6c
@grolu
Copy link
Contributor

grolu commented Aug 14, 2018

Added required to all fields. It would be possible to make better validation checks as we do for aws / google, however I don't know the exact params to do so.

@grolu grolu closed this as completed Aug 14, 2018
@grolu grolu mentioned this issue Aug 14, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@freegroup @grolu