Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make shoot spec defaults configurable #302

Closed
grolu opened this issue Feb 11, 2019 · 1 comment · Fixed by #416
Closed

Make shoot spec defaults configurable #302

grolu opened this issue Feb 11, 2019 · 1 comment · Fixed by #416
Assignees
@grolu
Labels
area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related component/dashboard Gardener Dashboard effort/2d Effort for issue is around 2 days exp/beginner Issue that requires only basic skills kind/enhancement Enhancement, improvement, extension

Comments

@grolu
Copy link
Contributor

grolu commented Feb 11, 2019

some values of the shoot spec are currently hard coded in the dashboard. An example is the CIDR range, but there may be more things that we should make configurable.
@grolu grolu added kind/enhancement Enhancement, improvement, extension exp/beginner Issue that requires only basic skills component/dashboard Gardener Dashboard size/s Size of pull request is small (see gardener-robot robot/bots/size.py) area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related status/accepted Issue was accepted as something we need to work on labels Feb 11, 2019
@grolu grolu self-assigned this Apr 2, 2019
@grolu
Copy link
Contributor Author

grolu commented Apr 2, 2019

part of #208

This was referenced Apr 10, 2019
Closed
Closed
@gardener-robot-ci-1 gardener-robot-ci-1 added lifecycle/stale Nobody worked on this for 6 months (will further age) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Jun 2, 2019
@grolu grolu mentioned this issue Jun 25, 2019
Merged
@gardener-robot-ci-1 gardener-robot-ci-1 added lifecycle/stale Nobody worked on this for 6 months (will further age) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Aug 2, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 removed the status/accepted Issue was accepted as something we need to work on label Aug 24, 2019
@gardener-robot gardener-robot added effort/2d Effort for issue is around 2 days and removed size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grolu grolu

Labels
area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related component/dashboard Gardener Dashboard effort/2d Effort for issue is around 2 days exp/beginner Issue that requires only basic skills kind/enhancement Enhancement, improvement, extension
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor create shoot gardener/dashboard
3 participants
@gardener-robot-ci-1 @grolu @gardener-robot