Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor create shoot #416

Merged
merged 64 commits into from Aug 23, 2019
Merged

Refactor create shoot #416

merged 64 commits into from Aug 23, 2019

Conversation

grolu
Copy link
Contributor

@grolu grolu commented Jun 25, 2019 •
edited

What this PR does / why we need it:
This PR replaces the Create Cluster Popup with a dedicated create cluster page. The user can now switch between UI and yaml mode when creating clusters (using the same UI paradigm as on the cluster details page). This solves several issues by allowing the user to configure the shoot resource before creating the cluster (which is required for some things, e.g. dns settings)

Which issue(s) this PR fixes:
Fixes #208 Fixes #340 Fixes #302 Fixes #23 Fixes #432 Fixes #390 Fixes #415 Fixes #435 Fixes #318

Special notes for your reviewer:
Screen Shot 2019-06-28 at 09 10 58
Screen Shot 2019-06-28 at 09 11 25

Release note:

Create Cluster: Replaced create cluster popup with a dedicated create cluster page. You can now switch between UI and YAML mode when creating clusters. This allows to fine-tune the shoot resource by making custom configurations before the cluster is created #23

Worker Groups: You can now configure `Machine Image` and `Max. Surge` via the Dashboard UI

Maintenance: You can now disable automatic operating system updates of your workers #390

Availability Zones: You can now configure multiple availability zones for your cluster #432

Add-ons: Manage cluster add-ons on details page #302

Purpose: Easy change the purpose of a cluster after creation

Actions for clusters with purpose `infrastructure` are now disabled to avoid accidental operations on infrastructure clusters

grolu added 28 commits April 15, 2019 09:20
@grolu
[WIP]
64045b6
@grolu
Merge branch 'master' into refactor_create_shoot
d277be7 
# Conflicts:
#	frontend/src/components/HibernationScheduleEvent.vue
#	frontend/src/pages/ShootItemEditor.vue
#	frontend/src/router/index.js
@grolu
[WIP] Improved shoot resource updates between ui/yaml view
047d24c
@grolu
[WIP] switched to dedicated bus for communicating user interaction be…
f1ef3ca 
…tween create cluster components
@grolu
Merge branch 'master' into refactor_create_shoot
b50498b 
# Conflicts:
#	.secrets.baseline
@grolu
[WIP] Remove confirm navigation prompt when switching between yaml an…
8660094 
…d ui mode
@grolu
[WIP]
762a9b1
@grolu
[WIP] Fixed maintenance auto update handling
5d0e79c
@grolu
[WIP] fixed name check
47d8a71
@grolu
Merge branch 'master' into refactor_create_shoot
0c16f23 
# Conflicts:
#	.secrets.baseline
#	frontend/src/dialogs/CreateClusterDialog.vue
@grolu
[WIP] Support regions without seed
dcd7159 
removed unused files
@grolu
Merge branch 'master' into refactor_create_shoot
4feabdd
@grolu
Merge branch 'master' into refactor_create_shoot
278e585 
# Conflicts:
#	frontend/src/dialogs/CreateClusterDialog.vue
@grolu
[WIP]
3466748
@grolu
[WIP] Choose infrastructure card
946896d
@grolu
[WIP] Option to add secrets on create cluster page
3fadfb2
@grolu
[WIP]
072cfa9 
Select created secret after dialog close
Fixed some issues when switching from yaml to create ui (due to new select infrastructure card)
@grolu
[WIP] Fixed some validation issues
b632ddf
@grolu
Do not save via keyboard shortcuts if editor is in create mode
804bf5a
@grolu
Merge branch 'master' into refactor_create_shoot
c6d75c9
@grolu
Fixed some warnings
7ccef72
@grolu
removed old create cluster dialog leftovers
9f7e97d
@grolu
removed unused components
d5b430c 
added infrastructure name as text
reordered create cluster cards
some cleanup
@grolu
Added create cluster button to create shoot editor page
b845be4
@grolu
Removed accidentally checked in fakeprofile
ed08197
@grolu
Merge branch 'master' into refactor_create_shoot
701e196
@grolu
Merge branch 'master' into refactor_create_shoot
6fcf601
@grolu
Show confirm dialog when leaving create cluster page
75c7c29
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 20, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 20, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 20, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 21, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 22, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 22, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 23, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 23, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 23, 2019
@grolu grolu removed the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Aug 23, 2019
holgerkoser
holgerkoser approved these changes Aug 23, 2019
View reviewed changes
Copy link
Contributor

@holgerkoser holgerkoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@grolu grolu merged commit eb14e75 into master Aug 23, 2019
@grolu grolu mentioned this pull request Sep 2, 2019
Closed
@petersutter petersutter deleted the refactor_create_shoot branch September 10, 2019 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerkoser holgerkoser holgerkoser approved these changes

@petersutter petersutter Awaiting requested review from petersutter petersutter is a code owner

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
Projects
None yet
Milestone
No milestone
3 participants
@grolu @holgerkoser @gardener-robot-ci-1