Support DNS Provider Management #1026

grolu · 2021-05-25T18:45:55Z

What this PR does / why we need it:
This PR adds DNS Provider Management to the Gardener Dashboard.
This enables the end users to add and manage their DNS Secrets via the Dashboard. Furthermore cluster DNS settings can be configured during cluster creation as well as afterwards, if possible.

Which issue(s) this PR fixes:
Fixes #769 Fixes #616 Fixes #406

Special notes for your reviewer:
@mandelsoft The secrets page will get a redesign soon.
@holgerkoser Please give feedback to the store based eventing approach I introduced with this PR for the new DNS components (@/components/ShootDns/)

Release note:

External DNS Provider Support
- Add and manage DNS Provider Secrets
- Configure Shoot DNS Providers

# Conflicts: # backend/lib/services/cloudProviderSecrets.js # frontend/src/views/Secrets.vue

added first attempt of component state store synchronization

Show detailed dns provider information in popper Update dns implementation cluster domain immutable count dns secret references

holgerkoser · 2021-07-28T20:04:05Z

frontend/src/components/ShootDns/DnsConfiguration.vue

@@ -73,7 +73,8 @@ export default {
      }
    },
    reset () {
-      this.setDnsConfiguration(this.shootSpec.dns)
+      const noCustomDomain = !this.isCustomShootDomain


do not understand why we need this (see comment above)

holgerkoser · 2021-07-28T20:04:24Z

frontend/src/components/ShootDns/ManageDns.vue

@@ -106,6 +106,10 @@ export default {
    createMode: {
      type: Boolean,
      default: false
+    },
+    noCustomDomain: {


do not understand why we need this (see comment above)

holgerkoser · 2021-07-28T20:07:05Z

frontend/src/store/modules/shootStaging.js

+      primaryProviderId,
+      noCustomDomain


!primaryProviderId === noCustomDomain

holgerkoser · 2021-07-28T20:08:10Z

frontend/src/store/modules/shootStaging.js

    state.dnsDomain = domain
    state.dnsProviders = keyBy(providers, 'id')
    state.dnsProviderIds = map(providers, 'id')
    state.dnsPrimaryProviderId = primaryProviderId
-    state.dnsPrimaryProviderValid = !state.dnsDomain || !!state.dnsPrimaryProviderId
+    state.dnsPrimaryProviderValid = !state.dnsDomain || !!state.dnsPrimaryProviderId || noCustomDomain


since !primaryProviderId === noCustomDomain this means !!state.dnsPrimaryProviderId || noCustomDomain is always true?

I would add a property:

state.dnsPrimaryProviderRequired = !!primaryProviderId

but do not quite understand the reasoning behind it

This is not the case. This statement is only true for already created shoots. This is the whole purpose of my change. For created shoots without a custom domain, the domain field is populated by the custom domain, while dnsPrimaryProviderId undefined. However, the information if the shoot is already created is not avaialble in the store (or am i wrong?). Of course, we could also store this information but I thought it would be easier to understand if we provide the actual information in a central place (mixin).
Same applies for your comment above:

I absolutely do not understand why we need to introduce this component parameter. I though the goal of my last my last PR was to get rid of these kind of component parameters. All the necessary information is already available on the store.

We could get the information by evaluating both the dnsPrimaryProviderId store state and the created prop but I wanted to keep the logic in a central place. I did not put it inside the store, as we also need the computed prop for the details card which has nothing to do with the store... ?
Maybe we need to discuss this online

* PR feedback * rm whitespace

gardener-robot · 2021-07-30T15:07:07Z

@grolu You need rebase this pull request with latest master branch. Please check.

…enh/dns-secrets # Conflicts: # frontend/src/components/ShootDns/ManageDns.vue # frontend/src/store/modules/shootStaging.js

gardener-robot · 2021-07-31T03:02:19Z

@mandelsoft You have pull request review open invite, please check

holgerkoser · 2021-08-02T08:24:59Z

frontend/src/components/NewShoot/NewShootInfrastructureDetails.vue

+         @input="onUpdateSecret"
+         @update:valid="onSecretValid"></select-secret>


Suggested change

@input="onUpdateSecret"

@update:valid="onSecretValid"></select-secret>

@input="onUpdateSecret"

:valid="secretValid"

@update:valid="onSecretValid"></select-secret>

# Conflicts: # frontend/src/components/ShootWorkers/MachineImage.vue

holgerkoser

/lgtm

grolu added 21 commits April 9, 2021 13:03

Support managing of DNS Secrets

095d337

Renamed infrastructure service to cloudprovider

981654e

Merge branch 'master' into enh/dns-secrets

7f91bfc

update logos

f83194f

Merge branch 'master' into enh/dns-secrets

96a4ee9

# Conflicts: # backend/lib/services/cloudProviderSecrets.js # frontend/src/views/Secrets.vue

cropped cloudflare and infoblox icons

14458e1

Merge branch 'master' into enh/dns-secrets

92f37cb

WIP

7fe622f

WIP

dbfb04d

Finished implementation of create shoot manage dns section

c990ace

added first attempt of component state store synchronization

Merge branch 'master' into enh/dns-secrets

2f20cc6

Merge branch 'master' into enh/dns-secrets

1cb8605

Merge branch 'master' into enh/dns-secrets

b10edf8

WIP Show DNS Configuration on Shoot Details Page

e91de5d

Fixed Layout

9d97b74

Show worker group machine image icon

2557e9a

Show detailed dns provider information in popper Update dns implementation cluster domain immutable count dns secret references

fixed some validation & dialog reset issues

e3ff6ff

small fixes

8ba8bdf

Some changes to naming and fixed secret creation on poups

bda16f2

validate: primary dns provider cannot be changed after cluster creation

d88c04c

Merge branch 'master' into enh/dns-secrets

5c47ca4

gardener-robot added needs/review Needs review size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels May 25, 2021

gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 25, 2021

gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 25, 2021

rm log stmt

5dfcadd

gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 25, 2021

holgerkoser reviewed Jul 28, 2021

View reviewed changes

Some final fixes and improvement proposals for enh/dns-secret (#1069)

c84b397

* PR feedback * rm whitespace

gardener-robot added the needs/rebase Needs git rebase label Jul 30, 2021

gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 30, 2021

gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 30, 2021

grolu added 2 commits July 30, 2021 17:10

some fixes

a5f2fac

Merge branch 'enh/dns-secrets' of github.com:gardener/dashboard into …

7b6b3ec

…enh/dns-secrets # Conflicts: # frontend/src/components/ShootDns/ManageDns.vue # frontend/src/store/modules/shootStaging.js

gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 30, 2021

gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 30, 2021

rm emit

c47e1a8

gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 30, 2021

gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 30, 2021

holgerkoser reviewed Aug 2, 2021

View reviewed changes

Some fixes

3b83a24

gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 2, 2021

Merge branch 'master' into enh/dns-secrets

f4ecf24

# Conflicts: # frontend/src/components/ShootWorkers/MachineImage.vue

gardener-robot removed the needs/rebase Needs git rebase label Aug 2, 2021

gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 2, 2021

gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 2, 2021

holgerkoser approved these changes Aug 2, 2021

View reviewed changes

gardener-robot added reviewed/lgtm Has approval for merging and removed needs/second-opinion Needs second review by someone else labels Aug 2, 2021

grolu merged commit 87f78e5 into master Aug 2, 2021

grolu deleted the enh/dns-secrets branch August 2, 2021 10:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support DNS Provider Management #1026

Support DNS Provider Management #1026

grolu commented May 25, 2021 •

edited

holgerkoser Jul 28, 2021

holgerkoser Jul 28, 2021

holgerkoser Jul 28, 2021

holgerkoser Jul 28, 2021

holgerkoser Jul 28, 2021

grolu Jul 28, 2021

gardener-robot commented Jul 30, 2021

gardener-robot commented Jul 31, 2021

holgerkoser Aug 2, 2021

holgerkoser left a comment

		@input="onUpdateSecret"
		@update:valid="onSecretValid"></select-secret>

Support DNS Provider Management #1026

Support DNS Provider Management #1026

Conversation

grolu commented May 25, 2021 • edited

holgerkoser Jul 28, 2021

Choose a reason for hiding this comment

holgerkoser Jul 28, 2021

Choose a reason for hiding this comment

holgerkoser Jul 28, 2021

Choose a reason for hiding this comment

holgerkoser Jul 28, 2021

Choose a reason for hiding this comment

holgerkoser Jul 28, 2021

Choose a reason for hiding this comment

grolu Jul 28, 2021

Choose a reason for hiding this comment

gardener-robot commented Jul 30, 2021

gardener-robot commented Jul 31, 2021

holgerkoser Aug 2, 2021

Choose a reason for hiding this comment

holgerkoser left a comment

Choose a reason for hiding this comment

grolu commented May 25, 2021 •

edited