Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix privileged terminal container bug #1051

Merged
merged 1 commit into from
Jun 29, 2021
Merged

Fix privileged terminal container bug #1051

merged 1 commit into from
Jun 29, 2021

Conversation

petersutter
Copy link
Contributor

What this PR does / why we need it:
This PR fixes an issue where the field spec.host.pod.container.privileged was not set on the Terminal resource and hence the terminal-controller-manager did not create the terminal container with

securityContext:
  privileged: true

Which issue(s) this PR fixes:
Fixes #1050

Special notes for your reviewer:

Release note:

Fixed an issue where the terminal container was not created with `privileged` set to `true` of the `container`s `securityContext` when enabling the `Privileged` flag on the terminal settings UI

@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jun 25, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 25, 2021
@petersutter
Copy link
Contributor Author

cc @plkokanov, thanks for reporting the issue

@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 25, 2021
@gardener-robot
Copy link

@holgerkoser, @grolu You have pull request review open invite, please check

holgerkoser
holgerkoser approved these changes Jun 28, 2021
View reviewed changes
Copy link
Contributor

@holgerkoser holgerkoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\lgtm

grolu
grolu approved these changes Jun 29, 2021
View reviewed changes
Copy link
Contributor

@grolu grolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jun 29, 2021
@petersutter petersutter merged commit 82bedc2 into master Jun 29, 2021
@petersutter petersutter deleted the bug/privileged-terminal-container branch June 29, 2021 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerkoser holgerkoser holgerkoser approved these changes

@grolu grolu grolu approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ops-toolbelt container in terminal pod is not started with privileged security context when specified
5 participants
@petersutter @gardener-robot @holgerkoser @grolu @gardener-robot-ci-1