Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hotfix 1.51] Unify width of dialogs #1075

Merged
merged 1 commit into from Aug 9, 2021
Merged

[hotfix 1.51] Unify width of dialogs #1075

merged 1 commit into from Aug 9, 2021

Conversation

holgerkoser
Copy link
Contributor

@holgerkoser holgerkoser commented Aug 9, 2021 •
edited by grolu

What this PR does / why we need it:
This PR unifies the default width of all dialogs to four sizes 450px, 600px, 750px and 900px.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Fixes a bug with the size of dialogs. In some cases the dialogs were too small to display the complete content clearly. The size of all dialogs has been adjusted and unified

@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Aug 9, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 9, 2021
petersutter
petersutter approved these changes Aug 9, 2021
View reviewed changes
Copy link
Contributor

@petersutter petersutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

please also add a release note

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Aug 9, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 9, 2021
@holgerkoser holgerkoser merged commit 6b32189 into hotfix-1.51 Aug 9, 2021
@holgerkoser holgerkoser deleted the bug/dialog-width branch August 9, 2021 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petersutter petersutter petersutter approved these changes

@grolu grolu Awaiting requested review from grolu

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@holgerkoser @petersutter @gardener-robot-ci-2 @gardener-robot