Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hotfix-1.51] Fixes regarding worker cri configuration #1084

Merged
merged 1 commit into from Aug 12, 2021
Merged

[hotfix-1.51] Fixes regarding worker cri configuration #1084

merged 1 commit into from Aug 12, 2021

Conversation

grolu
Copy link
Contributor

@grolu grolu commented Aug 11, 2021

Existing workers may keep cri.name empty without failing validation
Selecting a container runtime validates correctly
Machine image included internal properties in create shoot editor
additional container runtimes selection did no longer show up

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Fixed some issues regarding creating and editing worker groups
- Existing worker groups may keep `cri.name` empty without failing validation
- Additional container runtimes selection did no longer show up
- Machine `worker.machine.image` included internal properties in create shoot editor

@grolu
Fixed:
66bd5fc 
Existing workers may keep cri.name empty without failing validation
Selecting a container runtime validates correctly
Machine image included internal properties in create shoot editor
additional container runtimes selection did no longer show up
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Aug 11, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 11, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 11, 2021
@holgerkoser holgerkoser changed the title [hotfix] Fixes regarding worker cri configuration [hotfix-1.51] Fixes regarding worker cri configuration Aug 11, 2021
holgerkoser
holgerkoser approved these changes Aug 11, 2021
View reviewed changes
Copy link
Contributor

@holgerkoser holgerkoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Aug 11, 2021
petersutter
petersutter approved these changes Aug 11, 2021
View reviewed changes
Copy link
Contributor

@petersutter petersutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@grolu grolu merged commit b760288 into hotfix-1.51 Aug 12, 2021
@petersutter petersutter deleted the fix/cri_required_hotfix branch September 6, 2021 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerkoser holgerkoser holgerkoser approved these changes

@petersutter petersutter petersutter approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@grolu @holgerkoser @petersutter @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot