Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hotfix-1.51] DNS provider w/o secretBinding should be readonly #1086

Merged
merged 1 commit into from Aug 12, 2021
Merged

[hotfix-1.51] DNS provider w/o secretBinding should be readonly #1086

merged 1 commit into from Aug 12, 2021

Conversation

holgerkoser
Copy link
Contributor

@holgerkoser holgerkoser commented Aug 12, 2021 •
edited by grolu

What this PR does / why we need it:
If no secret binding was found for a given secretName and the cluster is not new,
then we assume that the secret exists and was manually created.
The DNS provider row should not be changed in this case.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Fixed a problem in the DNS provider configuration that caused a newly added DNS provider to always be disabled on an existing cluster

@gardener-robot gardener-robot added needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Aug 12, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 12, 2021
grolu
grolu approved these changes Aug 12, 2021
View reviewed changes
Copy link
Contributor

@grolu grolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Aug 12, 2021
@holgerkoser holgerkoser merged commit 6e63755 into hotfix-1.51 Aug 12, 2021
@holgerkoser holgerkoser deleted the hotfix/dns-provider-without-secret-binding branch August 12, 2021 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grolu grolu grolu approved these changes

@petersutter petersutter Awaiting requested review from petersutter

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/m Size of pull request is medium (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@holgerkoser @grolu @gardener-robot-ci-2 @gardener-robot