Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented worker name validation #110 #122

Merged
merged 3 commits into from
Jul 4, 2018
Merged

Conversation

grolu
Copy link
Contributor

@grolu grolu commented Jul 3, 2018

Add worker name validation

max length: 15
has to be a valid subdomain name

Related issue: #110

Worker names are now validated in the dashboard: Worker names have to be valid subdomain names and each name has a maximum length of 15 characters.

@grolu
Copy link
Contributor Author

grolu commented Jul 3, 2018

Please wait for questions to be answered in linked issue before merging this PR

  • Done

@petersutter petersutter added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 4, 2018
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 4, 2018
Copy link
Contributor

@petersutter petersutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@petersutter petersutter merged commit 66d5b07 into master Jul 4, 2018
@grolu grolu deleted the worker_validation branch July 13, 2018 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants