Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show user error as dedicated icon #1239

Merged
merged 5 commits into from Jul 4, 2022
Merged

Show user error as dedicated icon #1239

merged 5 commits into from Jul 4, 2022

Conversation

grolu
Copy link
Contributor

@grolu grolu commented Jun 15, 2022 •
edited

What this PR does / why we need it:
Show user error as badge so that the underlying error is still visible, see also linked issue.

Screen Shot 2022-07-04 at 12 49 32

I'm not sure about the layout though. It looks kind of unsteady. We should discuss this.

Which issue(s) this PR fixes:
Fixes #1032

Special notes for your reviewer:

Release note:

Added dedicated icon for user errors in shoot status so that the underlying shoot status is still visible

@gardener-robot gardener-robot added needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Jun 15, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 15, 2022
@gardener-robot
Copy link

@holgerkoser You have pull request review open invite, please check

@holgerkoser
Copy link
Contributor

We always have the same problem of wanting to represent many different things in one property or icon. Maybe we should make a separate column for user issue. And we should also have some kind of advanced search for clusters. I wonder if we shouldn't address a general solution to the problem.

@grolu
Copy link
Contributor Author

grolu commented Jun 28, 2022

Maybe we should make a separate column for user issue

So you propose to add an additional column. Or shall we just add an additional icon just as @vpnachev proposed here: #1032

@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 29, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 30, 2022
@grolu grolu changed the title Show user error as badge Show user error as dedicated icvon Jun 30, 2022
@grolu grolu changed the title Show user error as dedicated icvon Show user error as dedicated icon Jun 30, 2022
holgerkoser
holgerkoser approved these changes Jul 4, 2022
View reviewed changes
Copy link
Contributor

@holgerkoser holgerkoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jul 4, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 4, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 4, 2022
@grolu grolu merged commit 1cb6516 into master Jul 4, 2022
@grolu grolu deleted the enh/hibernated_user_error branch July 4, 2022 10:50
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerkoser holgerkoser holgerkoser approved these changes

@petersutter petersutter Awaiting requested review from petersutter petersutter is a code owner

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use the icon for user issues also for hibernated clusters
6 participants
@grolu @gardener-robot @holgerkoser @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3