Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secret Navigation Fix #174

Merged
merged 2 commits into from
Aug 15, 2018
Merged

Secret Navigation Fix #174

merged 2 commits into from
Aug 15, 2018

Conversation

grolu
Copy link
Contributor

@grolu grolu commented Aug 15, 2018

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Fixed error when switching to 'All Projects' on Secrets page

…ojects' on secrets page

Added some explanations to router component
meta {
public: 'Determines weather route needs authorization',
namespaced: 'Determines weather route is namespace specific and has namespace in path',
projectscope: 'Determines weather route can be accessed in context of mutiple projects (_all)',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo, fix all: weather -> whether

@grolu grolu requested a review from petersutter August 15, 2018 15:15
@petersutter petersutter merged commit b766bc7 into master Aug 15, 2018
@petersutter petersutter deleted the fix_secret_routing branch August 16, 2018 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants