Fix too many project issue #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petersutter
reviewed
Aug 16, 2018
backend/lib/io.js
Outdated
| .filter(({namespace}) => !!_.find(projectList, ['metadata.namespace', namespace])) | ||
| .map(async ({namespace, filter}) => { | ||
|
|
||
| if (_.get(_.head(namespaces), 'namespace') === '_all') { |
There was a problem hiding this comment.
extract to variable _.head(namespaces)
petersutter
reviewed
Aug 16, 2018
backend/lib/io.js
Outdated
|
|
||
| if (_.get(_.head(namespaces), 'namespace') === '_all') { | ||
| try { | ||
| const filter = _.get(_.head(namespaces), 'filter') |
holgerkoser
reviewed
Aug 20, 2018
There was a problem hiding this comment.
Using lodash the code could be simplified a little bit:
const batchEmitObjects = _
.chain(batchEmitter)
.bindKey('batchEmitObjects')
.ary(2)
.value()
...
const hasIssue = item => filter !== 'issues' || shootHasIssue(item)
_
.chain(shootList)
.get('items')
.filter(hasIssue)
.groupBy('metadata.namespace')
.forEach(batchEmitObjects)
.commit()Use short variant when mapping Objects:
const namespaces = _.map(projectList, (project) => _.get(project, 'metadata.namespace'))
_.map(namespacesAndFilters, ({namespace}) => namespace)Shorter variant:
const namespaces = _.map(projectList, 'metadata.namespace')
_.map(namespacesAndFilters, 'namespace')
|
@holgerkoser I implemented and tested the changes proposed by you. In addition, I removed the filter statement(s) as I believe this is a leftover (before the apiserver set the unhealthy label). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We face issues when a user (operator) has access to many projects and tries to fetch the all shoots list. This PR adds a special handling for users that have the operator role. These users can fetch all shoots at once (without namespace selector). This way, we do not need to make a requests for each namespace to the Kubernetes API.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: