Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not show ingress url if nginx-ingress addon is disabled #199

Merged
merged 1 commit into from
Sep 28, 2018

Conversation

petersutter
Copy link
Contributor

What this PR does / why we need it:
Ingress domain is hidden when nginx-ingress addon is disabled

Which issue(s) this PR fixes:
Fixes #191

Special notes for your reviewer:

Release note:

Ingress domain is hidden on cluster details page if `nginx-ingress` addon is disabled

Copy link
Contributor

@holgerkoser holgerkoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@holgerkoser holgerkoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@petersutter petersutter merged commit 385dde4 into master Sep 28, 2018
@petersutter petersutter deleted the hide-ingress branch September 28, 2018 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ingress domain in cluster details page shown although nginx-ingress addon not deployed
2 participants