Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Customize HTTP Requests for JWKS endpoint #421

Merged
merged 1 commit into from Jul 1, 2019
Merged

Customize HTTP Requests for JWKS endpoint #421

merged 1 commit into from Jul 1, 2019

Conversation

holgerkoser
Copy link
Contributor

@holgerkoser holgerkoser commented Jul 1, 2019 •
edited by grolu

What this PR does / why we need it:
Customizing HTTP Requests in the new version of openid-client has to be done not only on the Issuer constructor for metadata discovery and the Client instance for token endpoint requests but also on the Issuer instance for jwks endpoint requests. We do not call this endpoint in the dashboard backend but the openid-client library calls it internally.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Use dashboard with an oidc provider that has a self generated Certificate Authority (CA)

@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 1, 2019
petersutter
petersutter approved these changes Jul 1, 2019
View reviewed changes
Copy link
Contributor

@petersutter petersutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@holgerkoser holgerkoser merged commit c861049 into master Jul 1, 2019
@holgerkoser holgerkoser deleted the oidc-http-options branch July 1, 2019 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petersutter petersutter petersutter approved these changes

@grolu grolu Awaiting requested review from grolu grolu is a code owner

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@holgerkoser @petersutter @gardener-robot-ci-1