Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make containerImageDescriptions optional #636

Merged
merged 1 commit into from Mar 20, 2020
Merged

Make containerImageDescriptions optional #636

merged 1 commit into from Mar 20, 2020

Conversation

petersutter
Copy link
Contributor

@petersutter petersutter commented Mar 20, 2020 •
edited

What this PR does / why we need it:
Make containerImageDescriptions configuration optional.

See example configuration here #543

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Fixed error: `No config with terminal.containerImageDescriptions found`. This configuration is now optional. See [gardener/dashboard#543](https://github.com/gardener/dashboard/pull/543) for an example of `terminal.containerImageDescriptions` configuration

@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 20, 2020
@petersutter petersutter merged commit c9c8b79 into master Mar 20, 2020
@petersutter petersutter deleted the enh/make-container-image-descriptions-optional branch March 20, 2020 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerkoser holgerkoser holgerkoser approved these changes

@grolu grolu Awaiting requested review from grolu grolu is a code owner

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@petersutter @holgerkoser @gardener-robot-ci-2