Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add namespace to create shoot resource #654

Merged
merged 1 commit into from Apr 3, 2020
Merged

add namespace to create shoot resource #654

merged 1 commit into from Apr 3, 2020

Conversation

grolu
Copy link
Contributor

@grolu grolu commented Apr 1, 2020

What this PR does / why we need it:
Add namespace to shoot resource.

Which issue(s) this PR fixes:
Fixes #653

Special notes for your reviewer:

Release note:

Fixed: `.metadata.namespace` missing in YAML representation of Create Cluster dialog

@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 1, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 1, 2020
holgerkoser
holgerkoser approved these changes Apr 2, 2020
View reviewed changes
Copy link
Contributor

@holgerkoser holgerkoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

petersutter
petersutter approved these changes Apr 2, 2020
View reviewed changes
Copy link
Contributor

@petersutter petersutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@grolu grolu merged commit a8e7636 into master Apr 3, 2020
@grolu grolu deleted the namespace_missing branch April 3, 2020 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerkoser holgerkoser holgerkoser approved these changes

@petersutter petersutter petersutter approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Namespace missing in YAML representation of Create Cluster dialog
5 participants
@grolu @holgerkoser @petersutter @gardener-robot-ci-1 @gardener-robot-ci-2