Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong default loadBalancerClasses for new shoots #787

Merged
merged 1 commit into from
Aug 21, 2020
Merged

Conversation

holgerkoser
Copy link
Contributor

@holgerkoser holgerkoser commented Aug 20, 2020

What this PR does / why we need it:
If the first supported infrastructure provider has load balancer classes in the cloudProfile the default list loadBalancerClasses in the shoot spec has the wrong format. As a result the default loadBalancerClass disabled and not selected.

Which issue(s) this PR fixes:
Fixes #786

Special notes for your reviewer:

Release note:

The default load balancer class for new shoot is selected correctly

@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 20, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 20, 2020
Copy link
Contributor

@petersutter petersutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@holgerkoser holgerkoser merged commit 7a474ad into master Aug 21, 2020
@holgerkoser holgerkoser deleted the fix-786 branch August 21, 2020 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong default loadBalancerClasses for new shoots
4 participants