Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show Secrets as Table List #937

Merged
merged 30 commits into from
Feb 24, 2021
Merged

Show Secrets as Table List #937

merged 30 commits into from
Feb 24, 2021

Conversation

grolu
Copy link
Contributor

@grolu grolu commented Jan 19, 2021 •
edited

What this PR does / why we need it:
We now use a Table to show the Secrets. This aligns the Secret page with the other pages.
It is also a preparation for the new Secret types that we plan to implement, e.g. DNS Provider Secrets.

Screen Shot 2021-01-25 at 12 15 36

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
With this PR we remove the demo providers / disabled cloud providers (Digital Ocean, China Telecom, Nutanix) from the code.

Release note:

Secrets can now be filtered and are sortable using a table layout

@gardener-robot gardener-robot added needs/review Needs review size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Jan 19, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 19, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 19, 2021
@grolu grolu marked this pull request as ready for review January 19, 2021 19:03
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 19, 2021
petersutter
petersutter reviewed Jan 20, 2021
View reviewed changes
frontend/src/components/NewShoot/NewShootSelectInfrastructure.vue Outdated
@@ -12,11 +12,12 @@ SPDX-License-Identifier: Apache-2.0
:class="{ 'select_infra_card_active elevation-4' : infrastructureKind == selectedInfrastructure }"
@click="selectInfrastructure(infrastructureKind)"
:key="infrastructureKind"
:color="darkMode ? 'grey darken-2' : undefined"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in dark mode it is hard to tell which infrastructure is selected

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I worked on the select infrastructure cards. Still not perfect, maybe we can have another look

@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 25, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 23, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 23, 2021
@grolu
Merge branch 'master' into enh/secret-table
0c89842 
# Conflicts:
#	frontend/src/components/DisabledSecret.vue
#	frontend/src/components/Secret.vue
#	frontend/src/components/dialogs/SecretDialogAlicloudHelp.vue
#	frontend/src/components/dialogs/SecretDialogAwsHelp.vue
#	frontend/src/components/dialogs/SecretDialogAzureHelp.vue
#	frontend/src/components/dialogs/SecretDialogGcpHelp.vue
#	frontend/src/components/dialogs/SecretDialogHelp.vue
#	frontend/src/components/dialogs/SecretDialogMetalHelp.vue
#	frontend/src/components/dialogs/SecretDialogOpenstackHelp.vue
#	frontend/src/components/dialogs/SecretDialogVSphereHelp.vue
@gardener-robot gardener-robot removed the needs/rebase Needs git rebase label Feb 23, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 23, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 23, 2021
@petersutter
Copy link
Contributor

when changing changing the secret table options, e.g. when I hide columns and press reload, the changes are reset

@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 23, 2021
@grolu @petersutter
Apply suggestions from code review
559cae6 
Co-authored-by: Peter Sutter <peter.sutter@sap.com>
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 23, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 23, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 23, 2021
holgerkoser
holgerkoser approved these changes Feb 24, 2021
View reviewed changes
Copy link
Contributor

@holgerkoser holgerkoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\lgtm

@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 24, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 24, 2021
petersutter
petersutter approved these changes Feb 24, 2021
View reviewed changes
Copy link
Contributor

@petersutter petersutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm however I still can't properly see which infrastructure is selected on the create cluster page with dark mode

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Feb 24, 2021
@grolu
Copy link
Contributor Author

grolu commented Feb 24, 2021

/lgtm however I still can't properly see which infrastructure is selected on the create cluster page with dark mode

Ok, let's discuss this in the theming PR where we also fine-tune the colors

@grolu grolu merged commit 05f9134 into master Feb 24, 2021
@grolu grolu deleted the enh/secret-table branch February 24, 2021 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerkoser holgerkoser holgerkoser approved these changes

@petersutter petersutter petersutter approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@grolu @petersutter @holgerkoser @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot