Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Info / About Dialog #951

Merged
merged 4 commits into from
Feb 23, 2021
Merged

Added Info / About Dialog #951

merged 4 commits into from
Feb 23, 2021

Conversation

grolu
Copy link
Contributor

@grolu grolu commented Feb 18, 2021

What this PR does / why we need it:

  • Added Info dialog to show Dashboard and Gardener Versions and a list of deployed extensions
  • Replaced Copyright Year with 2021

Screenshot 2021-02-18 at 17 15 10

Screenshot 2021-02-21 at 12 23 11

Which issue(s) this PR fixes:
Fixes #452 Fixes #498

Special notes for your reviewer:

Release note:

Moved Dashboard and Gardener version information to a dedicated dialog
Operators with admin role can now view a list of the deployed extensions for the Gardener landscape that the Dashboard is connected to

@gardener-robot gardener-robot added needs/review Needs review size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Feb 18, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 18, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 18, 2021
Replaced Copyright Year with 2021
@grolu grolu force-pushed the enh/show_deployed_extensions branch from a1c84e9 to 1b93414 Compare February 18, 2021 16:30
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 18, 2021
@petersutter
Copy link
Contributor

have you checked how the extensions would look like as columnar layout or as table?

@grolu
Copy link
Contributor Author

grolu commented Feb 19, 2021

have you checked how the extensions would look like as columnar layout or as table?

as a first proposal, I restored the expansion panel I already implemented in the last draft. Let's collect some ideas how we can improve. A table certainly is an option, also I like to know if you like the rest of this dialog and also the About Button in the Menu. Last time we also discussed f this dialog should open with a click on the Gardener Logo. WDYT?

@petersutter
Copy link
Contributor

I'd prefer the to open this dialog on the about button. At first look I like it very much, however we should display the version information consistently for both the version information at the top and the extension versions below. Collapsing the extension list by default makes sense, I like it.
Can / should the copyright section at the bottom be configurable / hide-able?

@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 21, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 21, 2021
Co-authored-by: Holger Koser <holger.koser@sap.com>
Co-authored-by: Peter Sutter <peter.sutter@sap.com>
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 22, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 22, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 22, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 22, 2021
Copy link
Contributor

@holgerkoser holgerkoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\lgtm

@grolu grolu merged commit d5a8cba into master Feb 23, 2021
@grolu grolu deleted the enh/show_deployed_extensions branch February 23, 2021 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review needs/second-opinion Needs second review by someone else size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show deployed extensions + versions Support Gardener Extensions in Dashboard
7 participants