-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Info / About Dialog #951
Conversation
Replaced Copyright Year with 2021
a1c84e9
to
1b93414
Compare
have you checked how the extensions would look like as columnar layout or as table? |
as a first proposal, I restored the expansion panel I already implemented in the last draft. Let's collect some ideas how we can improve. A table certainly is an option, also I like to know if you like the rest of this dialog and also the About Button in the Menu. Last time we also discussed f this dialog should open with a click on the Gardener Logo. WDYT? |
I'd prefer the to open this dialog on the about button. At first look I like it very much, however we should display the version information consistently for both the version information at the top and the extension versions below. Collapsing the extension list by default makes sense, I like it. |
Co-authored-by: Holger Koser <holger.koser@sap.com> Co-authored-by: Peter Sutter <peter.sutter@sap.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
\lgtm
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #452 Fixes #498
Special notes for your reviewer:
Release note: