Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rel-1.2.0] [prober] Skip Leases belonging to non-existing Nodes #108

Merged
merged 6 commits into from
Mar 20, 2024
Merged

[rel-1.2.0] [prober] Skip Leases belonging to non-existing Nodes #108

merged 6 commits into from
Mar 20, 2024

Conversation

gardener-ci-robot
Copy link

@gardener-ci-robot gardener-ci-robot commented Mar 20, 2024 •
edited

This is an automated cherry-pick of #106

/assign rishabh-11

`dependency-watchdog-prober` now skips `Lease`s in the `kube-node-lease` namespace in case the corresponding `Node` does not exist (anymore).

@gardener-ci-robot gardener-ci-robot mentioned this pull request Mar 20, 2024
Merged
@gardener-ci-robot gardener-ci-robot added the kind/enhancement Enhancement, improvement, extension label Mar 20, 2024
@gardener-prow gardener-prow bot added cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 20, 2024
rishabh-11
rishabh-11 approved these changes Mar 20, 2024
View reviewed changes
Copy link
Collaborator

@rishabh-11 rishabh-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 20, 2024
@gardener-prow Gardener Prow
Copy link

gardener-prow bot commented Mar 20, 2024

LGTM label has been added.

Git tree hash: 3eac349c2d4f975a7487422c4ac4811f9c05d746

@gardener-prow Gardener Prow
Copy link

gardener-prow bot commented Mar 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rishabh-11

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 20, 2024
@gardener-prow gardener-prow bot merged commit 9ad4eb8 into gardener:rel-1.2.0 Mar 20, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rishabh-11 rishabh-11 rishabh-11 approved these changes

@unmarshall unmarshall Awaiting requested review from unmarshall

Assignees

@rishabh-11 rishabh-11

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@gardener-ci-robot @rishabh-11 @gardener-robot-ci-1 @gardener-robot-ci-3 @rfranzke