Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass db quota size config to embedded etcd used by restorer #134

Merged
merged 1 commit into from Mar 12, 2019
Merged

Pass db quota size config to embedded etcd used by restorer #134

merged 1 commit into from Mar 12, 2019

Conversation

shreyas-s-rao
Copy link
Collaborator

What this PR does / why we need it:
This PR fixes the bug where large size etcd data (greater than 2GB) could not be restored due to the backend quota size not being configured on the embedded etcd instance that is started on the backup sidecar to apply delta snapshots during restoration.

Which issue(s) this PR fixes:
Fixes #133

Special notes for your reviewer:

Release note:

Added the `embedded-etcd-quota-bytes` flag to allow configuring the backend quota size of the embedded etcd instance used during restoration of data.

@shreyas-s-rao shreyas-s-rao added kind/bug Bug component/etcd-backup-restore ETCD Backup & Restore platform/all needs/lgtm Needs approval for merging needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 11, 2019
@shreyas-s-rao shreyas-s-rao added this to the 0.5.2 milestone Mar 11, 2019
@shreyas-s-rao shreyas-s-rao force-pushed the embedded-etcd-quota-size branch 2 times, most recently from 97fcaac to 9025397 Compare March 12, 2019 05:28
swapnilgm
swapnilgm approved these changes Mar 12, 2019
View reviewed changes
Copy link
Contributor

@swapnilgm swapnilgm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@swapnilgm swapnilgm added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging and removed needs/lgtm Needs approval for merging needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 12, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 12, 2019
@shreyas-s-rao shreyas-s-rao added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 12, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 12, 2019
@swapnilgm swapnilgm merged commit d232be4 into gardener:master Mar 12, 2019
@shreyas-s-rao shreyas-s-rao deleted the embedded-etcd-quota-size branch March 12, 2019 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swapnilgm swapnilgm swapnilgm approved these changes

@georgekuruvillak georgekuruvillak Awaiting requested review from georgekuruvillak

Assignees
No one assigned
Labels
component/etcd-backup-restore ETCD Backup & Restore kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/all reviewed/lgtm Has approval for merging
Projects
None yet
Milestone
0.5.2
Development

Successfully merging this pull request may close these issues.

[BUG] Need to pass etcd configuration to embedded etcd during restoration
3 participants
@shreyas-s-rao @swapnilgm @gardener-robot-ci-1