Fix integration test setup script #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shreyas Rao <shreyas.sriganesh.rao@sap.com>
shreyas-s-rao
added
kind/bug
shreyas-s-rao
requested review from
georgekuruvillak and
swapnilgm
as code owners
gardener-robot-ci-2
added
reviewed/ok-to-test
swapnilgm
reviewed
Apr 6, 2020
There was a problem hiding this comment.
LGTM . But can we directly use the method mentioned here : https://docs.aws.amazon.com/cli/latest/userguide/install-cliv2-linux.html
|
@swapnilgm I tried that out. But the unzipping step itself is taking around 2 minutes, whereas using the pip method takes less than 30 seconds. Keeping time constraint in mind, I would suggest let's keep the pip approach itself. WDYT? |
|
Ahh ok. 👍 |
swapnilgm
approved these changes
Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shreyas Rao shreyas.sriganesh.rao@sap.com
What this PR does / why we need it:
This PR fixes recent apt issue for installing pip tool during integration test setup.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: