Skip the full snapshot if initial delta snapshot is taken and #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swapnilgm
requested review from
georgekuruvillak and
shreyas-s-rao
as code owners
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-1
added
needs/ok-to-test
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
swapnilgm
changed the title
|
Can we reduce the full snapshot "recent" duration to something like 15 or 30 minutes? So that sidecar can will take full snapshot only if last full snapshot was more than 30 minutes ago. This is because when etcd starts restarting, there's a higher chance of a data corruption and restoration, and this restoration will take longer if the last full snapshot was taken too long ago. A full snapshot taken 30 minutes ago will have far lesser number of delta snapshots, so the restoration will be quick and there's a smaller downtime there. WDYT? |
|
I think restoration time is separate problem. Let's not try to solve it here. Currently we are fine with whatever RPO its provides. The restoration time in generic issue and should be solved with compaction idea that we have in backlog. |
last full snapshot is within 24hr Signed-off-by: Swapnil Mhamane <swapnil.mhamane@sap.com>
gardener-robot-ci-2
added
reviewed/ok-to-test
|
@shreyas-s-rao @georgekuruvillak If you don't have any further concerns, can we merge this? |
shreyas-s-rao
approved these changes
Apr 24, 2020
gardener-robot-ci-2
added
the
reviewed/ok-to-test
|
I have updated the bootstrap script. Please go through it once and merge this. |
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
shreyas-s-rao
requested changes
Apr 24, 2020
chart/etcd-backup-restore/templates/etcd-bootstrap-configmap.yaml
Outdated
Show resolved
Hide resolved
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
Signed-off-by: Swapnil Mhamane <swapnil.mhamane@sap.com> Update chart/etcd-backup-restore/templates/etcd-bootstrap-configmap.yaml Co-Authored-By: Shreyas Rao <42259948+shreyas-s-rao@users.noreply.github.com>
gardener-robot-ci-2
added
reviewed/ok-to-test
|
if your queries has been resolved. Will you merge this PR. |
|
/lgtm |
ghost
added
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
last full snapshot is within 24hr
Signed-off-by: Swapnil Mhamane swapnil.mhamane@sap.com
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #221
Special notes for your reviewer:
Release note: