Fix etcd image for tests #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shreyas Rao <shreyas.sriganesh.rao@sap.com>
gardener-robot
added
needs/review
gardener-robot-ci-1
added
reviewed/ok-to-test
gardener-robot-ci-3
added
needs/ok-to-test-tm
gardener-robot-ci-2
added
needs/ok-to-test
|
@amshuman-kr the |
amshuman-kr
approved these changes
Nov 3, 2020
There was a problem hiding this comment.
LGTM. However, I am unable to run performance regression test because go get is no longer working for etcd benchmark due to etcd-io/etcd#12124 (comment). Considering that the issue on etcd has been open now for 4 months should we go ahead and merge this PR already?
|
Tangent: I have created #281 to track the movement of performance regression test to test machinery integration tests. |
|
@amshuman-kr Yes, we can address the perf regression tests in a separate PR, where we integrate it with the TM tests. Merging this PR now. |
34 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shreyas Rao shreyas.sriganesh.rao@sap.com
What this PR does / why we need it:
This PR fixes failing TM tests due to etcd version mismatch.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: