Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated compact subcommand to throw warning instead of error if revisions are already compacted #358

Merged
merged 1 commit into from Jul 15, 2021
Merged

Updated compact subcommand to throw warning instead of error if revisions are already compacted #358

merged 1 commit into from Jul 15, 2021

Conversation

shreyas-s-rao
Copy link
Collaborator

What this PR does / why we need it:
Rebased cherry-pick of #355

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Compaction job will now throw warning instead of error if revisions are already compacted

@shreyas-s-rao shreyas-s-rao added this to the v0.13.0 milestone Jul 15, 2021
@shreyas-s-rao shreyas-s-rao requested a review from a team as a code owner July 15, 2021 09:58
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jul 15, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 15, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 15, 2021
@shreyas-s-rao shreyas-s-rao mentioned this pull request Jul 15, 2021
Closed
@shreyas-s-rao shreyas-s-rao added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 15, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 15, 2021
@shreyas-s-rao
Copy link
Collaborator Author

@abdasgupta PTAL

@abdasgupta abdasgupta merged commit 8bfb6c3 into gardener:master Jul 15, 2021
@shreyas-s-rao shreyas-s-rao deleted the fix/compact-error-handling branch July 16, 2021 10:56
@shreyas-s-rao shreyas-s-rao mentioned this pull request Jun 27, 2023
Closed
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
v0.13.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@shreyas-s-rao @abdasgupta @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot @aaronfern