-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes copy operation for Swift snapstore #476
Conversation
/cc @ishan16696 |
yes, I also noticed this when I was working on the secret rotation PR and wondered why you guys are reading secret this way when
|
ok, do you want a hotfix release for backup-restore v0.15.3 ? |
17583c5
to
cacf256
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
Hey, @ishan16696 I see that this has not been cherry picked on 0.16.0 release which has the same problem. Can we cherry pick it there as well asap? |
What this PR does / why we need it:
Fixes the retrieval of credentials when using the copy operation with the
Swift
snapstore.Without this fix we get the following error when trying to copy backups:
This is because the
getClientOpts
function was exiting too soon ifisSource==true
and was never trying to read the file containing the source store credentials.I've added the following code for backwards compatibility:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: