Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added logic for single node restoration after abrupt shutdown. #482

Merged
merged 1 commit into from
Jun 6, 2022
Merged

Added logic for single node restoration after abrupt shutdown. #482

merged 1 commit into from
Jun 6, 2022

Conversation

abdasgupta
Copy link
Contributor

@abdasgupta abdasgupta commented May 26, 2022 •
edited
Loading

What this PR does / why we need it:
If a node abruptly shutdown in ETCD multi node cluster, it checks revision before coming back up. If the revision number is lesser than the latest snapshot, it fails to restore. Whereas this check is necessary for a single node cluster, it's not necessary for a multinode setup. This PR takes care of both type of clusters.

Which issue(s) this PR fixes:
Fixes #481

Special notes for your reviewer:

Release note:

- An initial-cluster field is now expected in the ETCD config

@abdasgupta abdasgupta requested a review from a team as a code owner May 26, 2022 08:21
@gardener-robot gardener-robot added needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels May 26, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 26, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 26, 2022
@gardener-robot gardener-robot added size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) and removed size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels May 26, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 26, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 26, 2022
@aaronfern
Copy link
Contributor

/assign

@aaronfern
Copy link
Contributor

This PR adds support for single node restoration only from revision mismatches and not from data/PV corruption
Is this right?

@abdasgupta
Copy link
Contributor Author

This PR adds support for single node restoration only from revision mismatches and not from data/PV corruption
Is this right?

Yes. Only that.

timuthy
timuthy suggested changes May 30, 2022
View reviewed changes
pkg/initializer/validator/datavalidator.go Outdated Show resolved Hide resolved
test/e2e/integration/cloud_backup_test.go Show resolved Hide resolved
pkg/server/backuprestoreserver.go Show resolved Hide resolved
@gardener-robot gardener-robot added the needs/changes Needs (more) changes label May 30, 2022
ishan16696
ishan16696 requested changes Jun 1, 2022
View reviewed changes
pkg/initializer/validator/datavalidator.go Outdated Show resolved Hide resolved
test/e2e/integration/cloud_backup_test.go Outdated Show resolved Hide resolved
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 2, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 2, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 2, 2022
@ishan16696
Copy link
Member

ishan16696 commented Jun 2, 2022 •
edited
Loading

In CI pipeline Integration tests again went into this issue #483

@abdasgupta
Copy link
Contributor Author

/retest

@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 2, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 2, 2022
timuthy
timuthy approved these changes Jun 3, 2022
View reviewed changes
Copy link
Member

@timuthy timuthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can tell it looks good. Can you double check the test or re-run them please?

@ishan16696
Copy link
Member

Do not merge this PR. I have some doubts.
/do-not-merge

@gardener-robot gardener-robot added the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Jun 6, 2022
@ishan16696 ishan16696 removed the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Jun 6, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 6, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 6, 2022
@abdasgupta abdasgupta merged commit 3f475fe into gardener:master Jun 6, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jun 6, 2022
@abdasgupta abdasgupta deleted the single_restore branch June 6, 2022 19:41
@abdasgupta
Copy link
Contributor Author

Addresses #489

@ashwani2k ashwani2k mentioned this pull request Sep 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timuthy timuthy timuthy approved these changes

@ishan16696 ishan16696 ishan16696 approved these changes

@aaronfern aaronfern aaronfern approved these changes

Assignees

@aaronfern aaronfern

Labels
needs/changes Needs (more) changes needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Single node restoration for ETCD multinode cluster
8 participants
@abdasgupta @aaronfern @ishan16696 @timuthy @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot