Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UpdateMemberPeerURL only logs an error in case of failure #540

Merged
merged 1 commit into from
Sep 23, 2022
Merged

UpdateMemberPeerURL only logs an error in case of failure #540

merged 1 commit into from
Sep 23, 2022

Conversation

aaronfern
Copy link
Contributor

@aaronfern aaronfern commented Sep 21, 2022 •
edited

What this PR does / why we need it:
This PR updated the functionality of etcd member peer URL updation to only log an error in case of failure.
This is needed as sometimes etcd restoration takes longer to complete and etcd member peer URL updation failure will then cause the container to crash before the restoration can complete

Which issue(s) this PR fixes:
Fixes #539

Special notes for your reviewer:

Release note:

[bug-fix] backup-restore does not return error when it fails to update PeerURL of member.

@aaronfern aaronfern requested a review from a team as a code owner September 21, 2022 11:46
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Sep 21, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 21, 2022
ishan16696
ishan16696 requested changes Sep 21, 2022
View reviewed changes
pkg/server/backuprestoreserver.go Outdated Show resolved Hide resolved
@gardener-robot gardener-robot added the needs/changes Needs (more) changes label Sep 21, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 21, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 22, 2022
@ishan16696
Copy link
Member

Please add a appropriate release note:
Fix a bug: backup-restore shouldn’t return error when it fails to update PeerURL of member.

@aaronfern aaronfern added the needs/cherry-pick Needs to be cherry-picked to older version label Sep 22, 2022
@ishan16696
Copy link
Member

I'm unable to retrigger the pipeline, please do the force push to re-trigger the pipeline checks.

@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 22, 2022
@aaronfern aaronfern added needs/cherry-pick Needs to be cherry-picked to older version reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/cherry-pick Needs to be cherry-picked to older version labels Sep 23, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 23, 2022
@aaronfern aaronfern merged commit bd4f088 into gardener:master Sep 23, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishan16696 ishan16696 ishan16696 approved these changes

Assignees
No one assigned
Labels
needs/changes Needs (more) changes needs/cherry-pick Needs to be cherry-picked to older version needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] UpdateMemberPeerURL should just log an error message instead of returning the error
6 participants
@aaronfern @ishan16696 @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot