Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Move status update to a separate controller in druid #106

Closed
amshuman-kr opened this issue Oct 21, 2020 · 3 comments · Fixed by #133
Closed

[Feature] Move status update to a separate controller in druid #106

amshuman-kr opened this issue Oct 21, 2020 · 3 comments · Fixed by #133
Assignees
Labels
kind/enhancement Enhancement, improvement, extension priority/3 Priority (lower number equals higher priority) status/accepted Issue was accepted as something we need to work on

Comments

@amshuman-kr
Copy link
Collaborator

amshuman-kr commented Oct 21, 2020

Feature (What you would like to be added):
The main reconciliation loop in etcd-druid takes care of everything from updating the owned resources and updating the status in the Etcd resource. We should create a separate controller (still part of the etcd-druid controller manager) which reconciles only the status section of the Etcd resource.

Credit: @rfranzke ❤️

Motivation (Why is this needed?):
The main reconcilation loop is triggered only if the watch events pass some predicates. If the status update during the main reconcilation fails for any reason, the status in the Etcd resource might not be updated until the next gardener reconcilation event that matches the predicates.

Approach/Hint to the implement solution (optional):

@amshuman-kr amshuman-kr added the kind/enhancement Enhancement, improvement, extension label Oct 21, 2020
@amshuman-kr
Copy link
Collaborator Author

cc @rfranzke

@rfranzke
Copy link
Member

/normal

@gardener-robot gardener-robot added priority/normal status/accepted Issue was accepted as something we need to work on labels Oct 21, 2020
@abdasgupta
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Enhancement, improvement, extension priority/3 Priority (lower number equals higher priority) status/accepted Issue was accepted as something we need to work on
Projects
None yet
4 participants