Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Make Etcd CRD's spec.backup.store section immutable #213

Closed
shreyas-s-rao opened this issue Aug 3, 2021 · 1 comment · Fixed by #230
Closed

[Feature] Make Etcd CRD's spec.backup.store section immutable #213

shreyas-s-rao opened this issue Aug 3, 2021 · 1 comment · Fixed by #230
Assignees
Labels
area/backup Backup related kind/enhancement Enhancement, improvement, extension

Comments

@shreyas-s-rao
Copy link
Contributor

Feature (What you would like to be added):
Make Etcd CRD's spec.backup.store section immutable.

Motivation (Why is this needed?):
Make Etcd CRD's spec.backup.store section immutable so that the storage container location isn't allowed to change mid-usage of an etcd, due to potential mismatch of snapshotting and restoration locations, allowing restorations to happen from a different etcd's backup and rendering the shoot cluster unusable. Refer gardener/gardener#4454 for a fix already made on Gardener, although we still want druid to be resilient to potential undesirable changes to the Etcd resource.

Approach/Hint to the implement solution (optional):
Since CRD immutability is yet to be support (refer kubernetes/kubernetes#65973), it might make more sense to use something like a validating webhook on the Etcd resource updates.

/cc @amshuman-kr

@shreyas-s-rao shreyas-s-rao added area/backup Backup related kind/enhancement Enhancement, improvement, extension labels Aug 3, 2021
@vanjiii
Copy link
Contributor

vanjiii commented Sep 9, 2021

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/backup Backup related kind/enhancement Enhancement, improvement, extension
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants