Ensure backup entry name is generated only once using non-empty strings #4454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
area/control-plane
stoyanr
changed the title
|
/invite @timuthy @plkokanov @ialidzhikov |
amshuman-kr
previously approved these changes
Jul 30, 2021
|
/needs cherry-pick |
vpnachev
reviewed
Jul 30, 2021
stoyanr
force-pushed
the
fix-generate-backup-entry-name
branch
from
c84c05b
to
756af3d
Compare
This was referenced Jul 30, 2021
plkokanov
approved these changes
Jul 30, 2021
timuthy
approved these changes
Jul 30, 2021
voelzmo
reviewed
Jul 30, 2021
timuthy
added a commit
that referenced
this pull request
Jul 30, 2021
…upstream-release-v1.26 [release-v1.26] Automated cherry pick of #4454: Ensure backup entry name is generated only once using non-empty strings
stoyanr
added a commit
that referenced
this pull request
Jul 30, 2021
…upstream-release-v1.28 [release-v1.28] Automated cherry pick of #4454: Ensure backup entry name is generated only once using non-empty strings
stoyanr
added a commit
that referenced
this pull request
Jul 30, 2021
…upstream-release-v1.27 [release-v1.27] Automated cherry pick of #4454: Ensure backup entry name is generated only once using non-empty strings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area control-plane
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
This is intended as a quick fix to a recently observed issue that is caused by generating a backup entry name
--when deployingEtcdresources. It does not fix the root cause of the issue (likely some kind of data race), just aims to prevent it from happening by ensuring the backup entry name is generated correctly.See gardener/gardener-extension-provider-azure#328 (comment).
Release note: