Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make auto-compaction-mode and auto-compaction-retention configurable #157

Merged
merged 1 commit into from
Apr 22, 2021
Merged

Make auto-compaction-mode and auto-compaction-retention configurable #157

merged 1 commit into from
Apr 22, 2021

Conversation

ishan16696
Copy link
Member

@ishan16696 ishan16696 commented Apr 8, 2021 •
edited by shreyas-s-rao

What this PR does / why we need it:
This PR make auto-compaction-mode and auto-compaction-retention configurable for Etcd and for embedded-Etcd of backup-restore(CLI flags was Introduce in this PR) via etcd-resource spec as well as via helm-charts.

Which issue(s) this PR fixes:
Fixes #136

Special notes for your reviewer:

Release note:

Configure auto-compaction policy for etcd and backup sidecar's embedded etcd via Etcd resource via `.spec.sharedConfig.autoCompactionMode` and `.spec.sharedConfig.autoCompactionRetention`.

@ishan16696 ishan16696 requested a review from a team as a code owner April 8, 2021 04:24
@gardener-robot gardener-robot added needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Apr 8, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 8, 2021
@ishan16696 ishan16696 changed the title Make auto-compaction-mode and auto-compaction-retention configurable [WIP]Make auto-compaction-mode and auto-compaction-retention configurable Apr 8, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 8, 2021
@ishan16696
Copy link
Member Author

ishan16696 commented Apr 8, 2021 •
edited

These issues need to be addressed first before merge this PR.

@ishan16696 ishan16696 added the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Apr 8, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 19, 2021
@ishan16696 ishan16696 changed the title [WIP]Make auto-compaction-mode and auto-compaction-retention configurable Make auto-compaction-mode and auto-compaction-retention configurable Apr 19, 2021
@ishan16696 ishan16696 removed the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Apr 20, 2021
@ishan16696
Copy link
Member Author

These issues need to be addressed first before merge this PR.

Issues are addressed here and here.

@ishan16696 ishan16696 mentioned this pull request Apr 21, 2021
Merged
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 21, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 21, 2021
@gardener-robot
Copy link

@ishan16696 You need rebase this pull request with latest master branch. Please check.

@gardener-robot gardener-robot added the needs/rebase Needs git rebase label Apr 21, 2021
@gardener-robot gardener-robot removed the needs/rebase Needs git rebase label Apr 21, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 21, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 21, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 21, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 21, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 22, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 22, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 22, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 22, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 22, 2021
@ishan16696
Make auto-compaction-mode and auto-compaction-retention configurable …
40f7360 
…for Etcd and for embedded-Etcd via etcd-resource spec as well as via helm-charts.
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 22, 2021
shreyas-s-rao
shreyas-s-rao approved these changes Apr 22, 2021
View reviewed changes
Copy link
Contributor

@shreyas-s-rao shreyas-s-rao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ishan16696 thanks for making the requested changes and fixing the tests. LGTM
PS: I've also updated the release note. PTAL

@shreyas-s-rao shreyas-s-rao merged commit ba48ea6 into gardener:master Apr 22, 2021
@dependabot dependabot bot mentioned this pull request May 19, 2021
Merged
@amshuman-kr amshuman-kr mentioned this pull request May 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shreyas-s-rao shreyas-s-rao shreyas-s-rao approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Make it possible to have smaller auto-compaction-retention period for etcd
6 participants
@ishan16696 @gardener-robot @shreyas-s-rao @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3