Added cronjob to schedule regular backup compaction #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
area/backup
|
Thank you @aaronfern for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below. |
aaronfern
force-pushed
the
cronjob
branch
2 times, most recently
from
3569915
to
6167723
Compare
amshuman-kr
requested changes
Jul 5, 2021
There was a problem hiding this comment.
Thanks for the changes @aaronfern! Overall looks very good. Just some minor suggestions below.
|
/invite @abdasgupta @shreyas-s-rao @ishan16696 |
abdasgupta
reviewed
Jul 5, 2021
amshuman-kr
reviewed
Jul 7, 2021
|
@aaronfern You have pull request review with status CHANGES_REQUESTED, please check |
|
@shreyas-s-rao, @ishan16696 You have pull request review open invite, please check |
amshuman-kr
approved these changes
Jul 15, 2021
There was a problem hiding this comment.
/lgtm My comments are addressed. @abdasgupta can you please check if this looks fine for you too?
gardener-robot
added
reviewed/lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area backup
/kind enhancement
What this PR does / why we need it:
This PR enhances
etcd druidto allow it to create a cronjob to schedule regular backup compactions to limit the number of incremental snapshots needed at any point in time for restoration and ultimately improve etcd restoration performance.Cronjob is created based on a configurable etcd spec field
compactionScheduleWhich issue(s) this PR fixes:
Fixes #191
Special notes for your reviewer:
Release note: