Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added permission for statefulsets in etcd role #366

Merged
merged 2 commits into from
Jul 8, 2022
Merged

Added permission for statefulsets in etcd role #366

merged 2 commits into from
Jul 8, 2022

Conversation

aaronfern
Copy link
Contributor

@aaronfern aaronfern commented Jul 4, 2022 •
edited

How to categorize this PR?

/area high-availability
/area disaster-recovery

What this PR does / why we need it:
This PR adds permissions to the etcd role to enable etcd-backup-restore pods to fetch statefulsets

Which issue(s) this PR fixes:
Fixes partially gardener/etcd-backup-restore#488
Fixes partially #349

Special notes for your reviewer:

Release note:

`etcd-druid` will now also add statefulset permissions to the etcd role

@aaronfern aaronfern requested a review from a team as a code owner July 4, 2022 12:14
@gardener-robot gardener-robot added area/disaster-recovery Disaster recovery related area/high-availability High availability related needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jul 4, 2022
@aaronfern aaronfern mentioned this pull request Jul 4, 2022
Closed
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 4, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 4, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 4, 2022
@ishan16696
Copy link
Member

I guess you also require to make changes for RBAC here too

@aaronfern
Copy link
Contributor Author

aaronfern commented Jul 6, 2022 •
edited

Afaiu the permissions here are for the etcd-druid pod itself, whereas the permissions that are being added with this PR are for the etcd-backup-restore pod

Although, in any case, the rules here already have permissions for statefulsets

@aaronfern aaronfern mentioned this pull request Jul 6, 2022
Merged
@ishan16696
Copy link
Member

Afaiu the permissions here are for the etcd-druid pod itself

yes, make sense

@aaronfern aaronfern merged commit 911b15e into gardener:master Jul 8, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishan16696 ishan16696 ishan16696 approved these changes

Assignees
No one assigned
Labels
area/disaster-recovery Disaster recovery related area/high-availability High availability related needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@aaronfern @ishan16696 @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot