Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Localstack setup by utilizing S3 endpoint support #713

Merged

Conversation

seshachalam-yv
Copy link
Contributor

@seshachalam-yv seshachalam-yv commented Oct 17, 2023

How to categorize this PR?

/area dev-productivity
/area documentation
/kind enhancement

What this PR does / why we need it:
This PR simplifies the setup of LocalStack by leveraging the recent support for passing the endpoint to S3. The changes include modifications to the configuration files and scripts to accommodate this latest support, making it easier to set up and use Localstack.

Previously, the AWS CLI didn't provide support to pass an endpoint for the S3 service, requiring a workaround of rewriting the DNS from CoreDNS. With the recent support for passing the endpoint to S3, able to simplify the setup steps and remove the old workarounds.

  • Added documentation on setting up etcd-druid with Localstack locally on a Kind cluster.
  • Introduced new sample druid_v1alpha1_etcd_localstack.yaml for etcd CR with a Localstack store.
  • Added new sample AWS secret etcd-secret-localstack.yaml for Localstack.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Added documentation and sample configurations for simplifying Localstack setup, making it easier for developers to create a local testing environment using a Kind cluster.

@seshachalam-yv seshachalam-yv requested a review from a team as a code owner October 17, 2023 09:55
@gardener-robot gardener-robot added area/dev-productivity Developer productivity related (how to improve development) area/documentation Documentation related kind/enhancement Enhancement, improvement, extension needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Oct 17, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 17, 2023
@seshachalam-yv seshachalam-yv self-assigned this Oct 19, 2023
@gardener-robot gardener-robot added the needs/changes Needs (more) changes label Nov 3, 2023
Copy link
Contributor

@abdasgupta abdasgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for such a nice PR. I did not run the e2e tests with the changes. I think e2e tests should run fine with the changes in this PR. Still, before merging, run the e2e test once with this changes.

@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 7, 2023
@abdasgupta
Copy link
Contributor

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/changes Needs (more) changes needs/review Needs review labels Nov 7, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 7, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 9, 2023
@seshachalam-yv seshachalam-yv merged commit ac3e156 into gardener:master Nov 9, 2023
11 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Nov 9, 2023
@seshachalam-yv seshachalam-yv deleted the simplify-localstack-setup branch November 9, 2023 13:48
@shreyas-s-rao shreyas-s-rao added this to the v0.21.0 milestone Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dev-productivity Developer productivity related (how to improve development) area/documentation Documentation related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants