Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fit for Control Plane Migration for use in Gardener Ecosystem #90

Merged
merged 46 commits into from
Jun 30, 2020
Merged

Fit for Control Plane Migration for use in Gardener Ecosystem #90

merged 46 commits into from
Jun 30, 2020

Conversation

MartinWeindel
Copy link
Member

@MartinWeindel MartinWeindel commented Jun 16, 2020 •
edited by mandelsoft

What this PR does / why we need it:
This is a major refactoring of the underlying controller manager library and the DNS controller itself.

  • restructure + owner status + owner migration
  • CRD generation with validation
  • annotation resource to inject annotations for source objects
  • reference option for DNSEntry objects
  • statistics
  • generalization of rate limiter used by alicloud DNS provider for all DNS providers (adapted/reworked version of PR rate limiter for all dns providers #80)
  • support of DNS handler CLI options
  • simplify zone filter error handling
  • detect error for dnsnames matching hosted zone domains
  • synchronize entries in cache before activating new owners
  • improved error handling
  • update to improved controller manager library version

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

DNSAnnotation objects can be used to inject annotations normally set on source objects

reference option for dns entry objects

added generalized rate limiter for all DNS providers

mandelsoft and others added 30 commits June 16, 2020 13:39
@mandelsoft @MartinWeindel
restructure + owner status + owner migration
9ec91d3
@mandelsoft @MartinWeindel
continue owner status
9caa70f
@mandelsoft @MartinWeindel
synchronize entries before activating new owner
2218e24
@mandelsoft @MartinWeindel
first try for CRD generation
54547b7
@mandelsoft @MartinWeindel
type check for raw records
1bc5893
@mandelsoft @MartinWeindel
compound controller migration using finalizer groups
c5142ca
@mandelsoft @MartinWeindel
update generator
e355b4a
@MartinWeindel
added build-local-compound
7663a18
@mandelsoft @MartinWeindel
switch to generated CRD definitions
7fd866a
@mandelsoft @MartinWeindel
annotation resource to inject annotations
17c7056 
to dns source objects prior to processing by source controller
@mandelsoft @MartinWeindel
reference option for dns entry objects
e155cd9
@mandelsoft @MartinWeindel
cleanup old crd definitions
b51817f
@mandelsoft @MartinWeindel
fix dedlock during statistic update in provider deletion
39c3e34
@mandelsoft @MartinWeindel
fix race condition
9d46db4
@MartinWeindel
support functional test with compound
32088ac
@mandelsoft @MartinWeindel
race condition for statistic update
5aa501b
@mandelsoft @MartinWeindel
trigger entries for errorneous provider update
4875a51
@mandelsoft @MartinWeindel
rate limiter for failed provider reconcilation
dbd4bc5
@mandelsoft @MartinWeindel
CRD update
708b446
@mandelsoft @MartinWeindel
add some generic options to chart
9d5cfbe
@mandelsoft @MartinWeindel
update controller manager
73cc055
@mandelsoft @MartinWeindel
externalize statistic to separate request pool
a1148d6
@mandelsoft @MartinWeindel
support of dns handler CLI options
af25e81
@mandelsoft @MartinWeindel
handler option demo ali-cloud
c06d9ad
@mandelsoft @MartinWeindel
update lib
971c1c1
@MartinWeindel
deal with stale entries on provider changes and errors
4a8ab51
@MartinWeindel
Merge pull request #78 from SayakMukhopadhyay/master
dc01153 
Added documentation for Cloudflare DNS
@MartinWeindel
update to dev cycle v0.7.11-dev
3a3aabe
@MartinWeindel
rate limiter for all dns providers
e521d70
@MartinWeindel
avoid handler update race
0ea55c6
@gardener-robot
Copy link

@MartinWeindel Thank you for your contribution.

@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 16, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 16, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 16, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 16, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 16, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 17, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 17, 2020
@mandelsoft mandelsoft changed the title Testupdate Fit for Control Plane Migration for use in Gardener Ecosystem Jun 18, 2020
@MartinWeindel MartinWeindel merged commit 8122ea9 into master Jun 30, 2020
@MartinWeindel MartinWeindel deleted the testupdate branch June 30, 2020 12:37
@MartinWeindel MartinWeindel mentioned this pull request Jul 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mandelsoft mandelsoft Awaiting requested review from mandelsoft

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@MartinWeindel @gardener-robot @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @mandelsoft