fixed foreign sub domain in zone selection #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinWeindel
added
area/quality
gardener-robot-ci-1
added
reviewed/ok-to-test
MartinWeindel
force-pushed
the
selection-fix
branch
from
73f2c3d
to
bd71d6d
Compare
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
MartinWeindel
force-pushed
the
selection-fix
branch
from
bd71d6d
to
a7411c2
Compare
gardener-robot-ci-2
added
reviewed/ok-to-test
MartinWeindel
force-pushed
the
selection-fix
branch
from
a7411c2
to
b51a041
Compare
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
|
changes reviewed with @mandelsoft |
gardener-robot
added
priority/3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
If a hosted zone contains another hosted zone and both zones are accessible with the same account, the DNSEntries (e.g.
www.sub.my.domain) of the sub hosted zone (e.g.sub.my.domain) are currently wrongly assigned to the super hosted zone (e.g.my.domain).This is fixed with this PR.
Additionally, as the selection of included/excluded zones and domains is not trivial, this logic has been refactored to add unit testing.
Please note, that the DNS controller can only resolve this situation correctly, if the super hosted zone contains an NS record for the sub hosted zone
Which issue(s) this PR fixes:
Fixes #91
Special notes for your reviewer:
Release note: