Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cert manager to v1.3.1 #445

Merged
merged 2 commits into from
May 21, 2021
Merged

Update cert manager to v1.3.1 #445

merged 2 commits into from
May 21, 2021

Conversation

christianhuening
Copy link
Contributor

@christianhuening christianhuening commented Apr 21, 2021 •
edited by Diaphteiros
Loading

What this PR does / why we need it:
This updated cert-manager from 0.13.1 to the most recent version 1.3.1
Which issue(s) this PR fixes:
#439
Special notes for your reviewer:
N/A
Release note:

Update Cert-Manager to recent version `v1.3.1`. Due to the large version jump, deploying over an existing landscape is likely to fail.

`sow` version `3.3.0` or higher is required.

@christianhuening christianhuening requested a review from a team as a code owner April 21, 2021 15:09
@gardener-robot
Copy link

@christianhuening Thank you for your contribution.

@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Apr 21, 2021
@christianhuening christianhuening mentioned this pull request Apr 22, 2021
Merged
@christianhuening
Copy link
Contributor Author

christianhuening commented Apr 22, 2021 •
edited
Loading

This sow PR is required to deploy this properly: gardener/sow#42
Background: https://cert-manager.io/docs/installation/upgrading/upgrading-0.15-0.16/

@christianhuening
Copy link
Contributor Author

@Diaphteiros did you intentionally not merge this?

@Diaphteiros Diaphteiros reopened this May 19, 2021
@gardener-robot gardener-robot added the lifecycle/rotten Nobody worked on this for 12 months (final aging stage) label May 20, 2021
Diaphteiros
Diaphteiros approved these changes May 21, 2021
View reviewed changes
Copy link
Contributor

@Diaphteiros Diaphteiros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels May 21, 2021
@Diaphteiros Diaphteiros merged commit 2953b83 into gardener:master May 21, 2021
@Diaphteiros Diaphteiros mentioned this pull request May 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Diaphteiros Diaphteiros Diaphteiros approved these changes

Assignees
No one assigned
Labels
lifecycle/rotten Nobody worked on this for 12 months (final aging stage) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@christianhuening @gardener-robot @Diaphteiros